Issue 176680043: code review 176680043: [release-branch.go1.4] cmd/pprof: fix symbol resolution...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 176680043: code review 176680043: [release-branch.go1.4] cmd/pprof: fix symbol resolution... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rsc

Modified:
10 years, 3 months ago

Reviewers:
iant

CC:
golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] cmd/pprof: fix symbol resolution for remote profiles ««« CL 183080043 / b663cc7e6c15 cmd/pprof: fix symbol resolution for remote profiles Fixes issue 9199. LGTM=iant R=golang-codereviews, iant CC=austin, golang-codereviews, minux https://codereview.appspot.com/183080043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 62e8df46d18e1f4a30cf17bf0d14bce24ed8c724 https://code.google.com/p/go/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/pprof/internal/symbolizer/symbolizer.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 3 months ago (2014-12-03 19:14:46 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=a8374fb64418 *** [release-branch.go1.4] cmd/pprof: fix symbol resolution for remote profiles ««« CL ...

10 years, 3 months ago (2014-12-03 19:14:57 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages