Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 176530043: code review 176530043: tools/cmd/vet: check that cgo is enabled before testing it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by r
Modified:
11 years, 4 months ago
Reviewers:
bradfitz
CC:
rsc, bradfitz, golang-codereviews
Visibility:
Public.

Description

tools/cmd/vet: check that cgo is enabled before testing it Should fix the tools builders.

Patch Set 1 #

Patch Set 2 : diff -r 288397a506f9d2a9ca5f2ca31dbab1e834d3347e https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cmd/stringer/endtoend_test.go View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 4 months ago (2014-12-01 23:00:34 UTC) #1
bradfitz
LGTM On Dec 1, 2014 3:00 PM, <r@golang.org> wrote: > Reviewers: rsc, > > Message: ...
11 years, 4 months ago (2014-12-01 23:03:27 UTC) #2
r
11 years, 4 months ago (2014-12-01 23:15:31 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=c3d959302c8a&repo=tools ***

tools/cmd/vet: check that cgo is enabled before testing it
Should fix the tools builders.

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/176530043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b