Issue 1749041: code review 1749041: io SectionReader Seek rejects backward seek

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1749041: code review 1749041: io SectionReader Seek rejects backward seek

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by peterGo

Modified:
13 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, rminnich, adg

Visibility:
Public.

Description

io SectionReader Seek rejects backward seek Fixes issue 899.

Patch Set 1 #

Patch Set 2 : code review 1749041: io SectionReader Seek rejects backward seek #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/io/io.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

peterGo

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 10 months ago (2010-07-02 05:51:55 UTC) #1

rminnich

On 2010/07/02 05:51:55, PeterGo wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

13 years, 10 months ago (2010-07-04 15:52:04 UTC) #2

adg

On 2010/07/04 15:52:04, rminnich wrote: > On 2010/07/02 05:51:55, PeterGo wrote: > > Hello mailto:golang-dev@googlegroups.com ...

13 years, 9 months ago (2010-07-08 06:56:02 UTC) #3

adg

13 years, 9 months ago (2010-07-08 06:57:15 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=5af6f6656531 ***

io: fix SectionReader Seek to seek backwards

Fixes issue 899.

R=golang-dev, rminnich, adg
CC=golang-dev
http://codereview.appspot.com/1749041

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages