Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3051)

Issue 174760043: [dev.cc] code review 174760043: create new branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by rsc
Modified:
9 years, 6 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

create new branch This branch is for work on converting the remaining C code in package runtime to Go and then deleting the cc, 5c, 6c, and 8c directories. It is targeted to land at the beginning of the 1.5 cycle. The conversion will proceed one GOOS/GOARCH combination at a time; red lines on the dashboard are expected and okay. Once Linux and OS X are converted, help with other systems will be most welcome.

Patch Set 1 #

Patch Set 2 : diff -r 1fdfd7dfaedb1b7702141617e621ab7328a236a1 https://code.google.com/p/go #

Patch Set 3 : diff -r 1fdfd7dfaedb1b7702141617e621ab7328a236a1 https://code.google.com/p/go #

Patch Set 4 : diff -r f38460037b72814ac6eeb0bf678c03468a27445a https://code.google.com/p/go #

Patch Set 5 : diff -r f38460037b72814ac6eeb0bf678c03468a27445a https://code.google.com/p/go #

Patch Set 6 : diff -r f38460037b72814ac6eeb0bf678c03468a27445a https://code.google.com/p/go #

Patch Set 7 : diff -r f38460037b72814ac6eeb0bf678c03468a27445a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A dev.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...
9 years, 6 months ago (2014-11-10 01:33:30 UTC) #1
r
LGTM
9 years, 6 months ago (2014-11-10 01:34:23 UTC) #2
rsc
9 years, 6 months ago (2014-11-10 02:14:50 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d01dc127ac5e ***

[dev.cc] create new branch

This branch is for work on converting the remaining C code in
package runtime to Go and then deleting the cc, 5c, 6c, and 8c
directories. It is targeted to land at the beginning of the 1.5 cycle.

The conversion will proceed one GOOS/GOARCH combination
at a time; red lines on the dashboard are expected and okay.

Once Linux and OS X are converted, help with other systems
will be most welcome.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/174760043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b