Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2917)

Issue 174720043: code review 174720043: go.net/ipv6: update TODOs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by mikio
Modified:
10 years, 4 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

x/net/ipv6: update TODOs TODOs for stub files are unnecessary because they are stubs. Also adds TODOs that need to be treated for spurious word boundary access on some CPU architecture such as ARM, Power.

Patch Set 1 : diff -r 34976018d4f0cf09061e2ab776fe46f2f3249a12 https://code.google.com/p/go.net #

Total comments: 2

Patch Set 2 : diff -r aa73292ff82e467c4c0db0adf26f0b02f6d1471f https://code.google.com/p/go.net #

Patch Set 3 : diff -r 69996db1c92211d9aea524512fe7feda6555200e https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -38 lines) Patch
M ipv6/control_rfc2292_unix.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M ipv6/control_rfc3542_unix.go View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ipv6/control_stub.go View 1 chunk +0 lines, -4 lines 0 comments Download
M ipv6/control_windows.go View 1 chunk +4 lines, -4 lines 0 comments Download
M ipv6/dgramopt_stub.go View 4 chunks +0 lines, -12 lines 0 comments Download
M ipv6/genericopt_stub.go View 1 chunk +0 lines, -4 lines 0 comments Download
M ipv6/helper_stub.go View 1 chunk +0 lines, -3 lines 0 comments Download
M ipv6/icmp_solaris.go View 1 chunk +3 lines, -3 lines 0 comments Download
M ipv6/icmp_stub.go View 1 chunk +0 lines, -4 lines 0 comments Download
M ipv6/icmp_windows.go View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
10 years, 4 months ago (2014-11-09 14:28:05 UTC) #1
iant
https://codereview.appspot.com/174720043/diff/40001/ipv6/control_rfc2292_unix.go File ipv6/control_rfc2292_unix.go (right): https://codereview.appspot.com/174720043/diff/40001/ipv6/control_rfc2292_unix.go#newcode23 ipv6/control_rfc2292_unix.go:23: // TODO(mikio): fix spurious word boundary access Let's use ...
10 years, 4 months ago (2014-11-09 18:01:26 UTC) #2
mikio
ptal https://codereview.appspot.com/174720043/diff/40001/ipv6/control_rfc2292_unix.go File ipv6/control_rfc2292_unix.go (right): https://codereview.appspot.com/174720043/diff/40001/ipv6/control_rfc2292_unix.go#newcode23 ipv6/control_rfc2292_unix.go:23: // TODO(mikio): fix spurious word boundary access On ...
10 years, 4 months ago (2014-11-10 03:08:51 UTC) #3
iant
LGTM
10 years, 4 months ago (2014-11-10 16:10:03 UTC) #4
mikio
10 years, 4 months ago (2014-11-10 21:56:50 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=6554114436a5&repo=net ***

x/net/ipv6: update TODOs

TODOs for stub files are unnecessary because they are stubs.
Also adds TODOs that need to be treated for spurious word
boundary access on some CPU architecture such as ARM, Power.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/174720043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b