Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3673)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 17420043: CSS and sprite removal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by huwshimi
Modified:
10 years, 5 months ago
Reviewers:
benji, mp+192755
Visibility:
Public.

Description

CSS and sprite removal In this branch: - Improve font rendering on OSX. - Removed a whole bunch of unused sprites. - Removed a bunch of unused CSS, mostly related to the removed sprites. - Removed the chrome app manifest file. https://code.launchpad.net/~huwshimi/juju-gui/sprite-and-css-removal/+merge/192755 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : CSS and sprite removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-31 lines, -442 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/images/alert_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/bottom_bar.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/bottom_bar_big_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/bottom_bar_small_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/browser_home.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-app-servers-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-applications-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-cache-proxy-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-database-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-databases-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-databases-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-databases-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-databases-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-databases-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-server-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-servers-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-servers-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-servers-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-servers-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-file-servers-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm-misc-96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_120.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_160.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_50.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_64.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_96.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/charm_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/configure-cog.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/configure_title_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/destroy_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/dotted_divider.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/dropbox.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/facebook-click.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/facebook-hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/facebook-normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/getfile_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/getfile_button-pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/glyphicons-halflings.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/glyphicons-halflings-white.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/header_nav_border.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_noshadow_destroy.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_noshadow_view.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_shadow_destroy.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_shadow_relation.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_shadow_triangle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_shadow_triangle_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/icons/icon_shadow_view.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/juju.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/juju-128.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/juju-white.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/landscape_logo.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/landscape_machine.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/landscape_restart_round.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/landscape_security_round.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/landscape_updates.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/left_shadow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/on_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/on_middle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/on_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_1px.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_left_edge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_view_right_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_view_right_button_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_zoom_right_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_zoom_right_button_down_press.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/picker_zoom_right_button_up_press.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/right_shadow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/searchbox_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/slider_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/slider_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/tab_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/tab_marker.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/toggles.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/top_bar.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/top_bar_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/view_1px.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/view_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/view_left_edge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/view_right_edge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_1px.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_left_edge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/zoom_right_edge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/index.html View 1 chunk +61 lines, -65 lines 0 comments Download
M lib/templates.js View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/views/browser/charm-full.less View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/views/browser/token.less View 2 chunks +0 lines, -24 lines 0 comments Download
D lib/views/manifest.handlebars View 1 chunk +0 lines, -23 lines 0 comments Download
M lib/views/stylesheet.less View 1 10 chunks +8 lines, -418 lines 0 comments Download

Messages

Total messages: 3
huwshimi
Please take a look.
10 years, 5 months ago (2013-10-25 22:19:38 UTC) #1
benji
Looks great. There was just the one comment that needs some tweaking. LGTM https://codereview.appspot.com/17420043/diff/1/lib/views/stylesheet.less File ...
10 years, 5 months ago (2013-10-25 23:17:13 UTC) #2
huwshimi
10 years, 5 months ago (2013-10-25 23:25:18 UTC) #3 
*** Submitted:

CSS and sprite removal

In this branch:
- Improve font rendering on OSX.
- Removed a whole bunch of unused sprites.
- Removed a bunch of unused CSS, mostly related to the removed sprites.
- Removed the chrome app manifest file.

R=benji
CC=
https://codereview.appspot.com/17420043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b