Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2012)

Issue 174170043: Support user defined port.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by frankban
Modified:
9 years, 5 months ago
Reviewers:
rharding, jeff.pihach, mp+241802
Visibility:
Public.

Description

Support user defined port. Allow specifying a port on which the GUI server starts listening for requests. Tests: `make unittest`. QA: - bootstrap an environment; - `make deploy`; - wait for the unit to be deployed; - visit the GUI URL, ensure port 80 redirects to 443 as usual and the GUI works as usual; - switch to a customized port: `juju set juju-gui port=8080`; - ensure the GUI is no longer reachable at port 80 or 443, instead it works correctly if you visit `https://<GUI-URL>:8080/`; - switch to a another customized port: `juju set juju-gui port=443`; - this time the GUI is still listening on default port for HTTPS, but port 80 no longer redirects to HTTPS; - switch to an invalid port: `juju set juju-gui port=80000`; - the GUI refuses to do that, and it falls back to using the default configuration: ensure port 80 redirects to 443; - switch again to a customized valid port: `juju set juju-gui port=12345`; - ensure the GUI server is listening on that port; - finally, unset the port value: `juju unset juju-gui port`; - back to defaults: ensure port 80 redirects to 443; - destroy the environment. Done, thank you. https://code.launchpad.net/~frankban/charms/trusty/juju-gui/custom-port/+merge/241802 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Support user defined port. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -30 lines) Patch
M README.md View 2 chunks +5 lines, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 2 chunks +9 lines, -1 line 0 comments Download
M config/guiserver.conf.template View 1 chunk +3 lines, -0 lines 0 comments Download
M hooks/backend.py View 3 chunks +6 lines, -5 lines 0 comments Download
M hooks/utils.py View 6 chunks +43 lines, -4 lines 0 comments Download
M server/guiserver/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/manage.py View 3 chunks +27 lines, -3 lines 0 comments Download
M server/guiserver/tests/test_manage.py View 4 chunks +50 lines, -6 lines 0 comments Download
M tests/20-functional.test View 3 chunks +11 lines, -4 lines 0 comments Download
M tests/test_backends.py View 3 chunks +17 lines, -4 lines 0 comments Download
M tests/test_utils.py View 4 chunks +131 lines, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
9 years, 5 months ago (2014-11-14 13:54:15 UTC) #1
rharding
LGTM no QA. Jeff and Francesco thanks! People are going to love getting this feature ...
9 years, 5 months ago (2014-11-14 14:09:23 UTC) #2
jeff.pihach
LGTM QA OK This looks great and works great, thanks for taking over!
9 years, 5 months ago (2014-11-14 15:46:31 UTC) #3
frankban
*** Submitted: Support user defined port. Allow specifying a port on which the GUI server ...
9 years, 5 months ago (2014-11-14 15:50:12 UTC) #4
frankban
9 years, 5 months ago (2014-11-14 15:51:22 UTC) #5
Thanks for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b