Issue 1741056: Fixes based on internal code-review comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1741056: Fixes based on internal code-review comments

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by baran

Modified:
13 years, 9 months ago

Reviewers:
razmyslovich, Eran, viarheichyk

CC:
webdriver-mobile-eng_google.com

Base URL:
http://webkitdriver.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fixing whitespace issues as well. #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -68 lines)			Patch
M	hlwk/WebKit/hl/JavaBindings.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	hlwk/WebKit/hl/JavaBindings.cpp	View	1	9 chunks	+30 lines, -11 lines	1 comment	Download
M	hlwk/WebKit/hl/WebKitDriver.h	View	1	5 chunks	+23 lines, -31 lines	0 comments	Download
M	hlwk/WebKit/hl/WebKitDriver.cpp	View	1	4 chunks	+18 lines, -24 lines	0 comments	Download
M	hlwk/WebKit/hl/WebKitDriverPrivate.h	View	1	2 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eran

13 years, 9 months ago (2010-07-23 10:18:46 UTC) #3

LGTM.

http://codereview.appspot.com/1741056/diff/3001/4001
File hlwk/WebKit/hl/JavaBindings.cpp (right):

http://codereview.appspot.com/1741056/diff/3001/4001#newcode237
hlwk/WebKit/hl/JavaBindings.cpp:237: if (!res.width() || !res.height()) {
If one of them is not zero, you could return the actual height / width and 1 for
the other dimension.

Expand All Messages | Collapse All Messages