Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6867)

Issue 173560043: i#1648 LsaFreeMemory not found, Windows 8.1

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by toshi
Modified:
9 years, 5 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Reviewer: bruening@google.com i#1648 LsaFreeMemory not found, Windows 8.1 Fixes missing LsaFreeMemory in KernelBase.dll error on Windows 8.1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M core/win32/loader.c View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 4
toshi
9 years, 5 months ago (2014-11-21 00:50:08 UTC) #1
bruening
The Description is generally assumed to be the exact commit message, so: Suggestion: many history ...
9 years, 5 months ago (2014-11-21 05:19:59 UTC) #2
bruening
https://codereview.appspot.com/173560043/diff/1/core/win32/loader.c File core/win32/loader.c (right): https://codereview.appspot.com/173560043/diff/1/core/win32/loader.c#newcode1206 core/win32/loader.c:1206: * We ignore the version suffix ("-1-0", e.g.). Note ...
9 years, 5 months ago (2014-11-21 05:22:35 UTC) #3
bruening
9 years, 5 months ago (2014-11-23 03:59:19 UTC) #4
On 2014/11/21 05:19:59, bruening wrote:
> Suggestion: many history viewing tools use the first line of the commit as the
> summary, so it would be best to put what you have as the 2nd line
("i#1648...")
> first. 

It turns out this Reviewer line is what my suggested review upload script adds
so please
disregard this comment: your actual commit message starts after that Reviewer.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b