Issue 173410043: code review 173410043: goprotobuf: Fix proto.Clone operating on empty-but-non-...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 173410043: code review 173410043: goprotobuf: Fix proto.Clone operating on empty-but-non-... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dsymonds

Modified:
11 years ago

Reviewers:
djd

CC:
djd, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Fix proto.Clone operating on empty-but-non-nil []byte values.

Patch Set 1 #

Patch Set 2 : diff -r 26b4b5c8a6ec0e0bc5a8d2807c9f42f7d1bb291a https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 26b4b5c8a6ec0e0bc5a8d2807c9f42f7d1bb291a https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 26b4b5c8a6ec0e0bc5a8d2807c9f42f7d1bb291a https://code.google.com/p/goprotobuf #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	proto/clone.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello djd@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

11 years ago (2014-11-18 02:40:34 UTC) #1

dsymonds

11 years ago (2014-11-18 02:49:44 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=56382ee64914 ***

goprotobuf: Fix proto.Clone operating on empty-but-non-nil []byte values.

LGTM=djd
R=djd
CC=golang-codereviews
https://codereview.appspot.com/173410043

Expand All Messages | Collapse All Messages