Issue 17340043: Removes strictBundle flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 17340043: Removes strictBundle flag

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
mp+192748, matthew.scott

Visibility:
Public.

Description

Removes strictBundle flag Also includes a driveby to fix some of the onboarding tests https://code.launchpad.net/~hatch/juju-gui/remove-strict-bundle-flag/+merge/192748 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes strictBundle flag #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -17 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/bundle.js	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	test/data/browserbundle.json	View	1 chunk	+18 lines, -2 lines	0 comments	Download
M	test/test_browser_app.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/test_bundle_details_view.js	View	3 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

10 years, 6 months ago (2013-10-25 21:48:00 UTC) #4

*** Submitted:

Removes strictBundle flag

Also includes a driveby to fix some of the onboarding tests

R=matthew.scott
CC=
https://codereview.appspot.com/17340043

Expand All Messages | Collapse All Messages