Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162)

Issue 173200044: [dev.cc] code review 173200044: runtime: convert openbsd/386 port to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by jsing
Modified:
10 years, 4 months ago
Reviewers:
rsc
CC:
golang-codereviews, bradfitz, rsc
Visibility:
Public.

Description

runtime: convert openbsd/386 port to Go

Patch Set 1 #

Patch Set 2 : diff -r b8329e8fce1a13ec34f9cf6a0a0db75c08cbc5ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b8329e8fce1a13ec34f9cf6a0a0db75c08cbc5ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 56f3a790b67aff99cc0aa47b7d880fa1bd3b176b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -45 lines) Patch
M src/runtime/defs_openbsd_386.go View 1 3 chunks +38 lines, -26 lines 0 comments Download
M src/runtime/defs_openbsd_amd64.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/os1_openbsd.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_openbsd_386.go View 1 1 chunk +34 lines, -16 lines 0 comments Download

Messages

Total messages: 4
jsing
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to the dev.cc branch of https://go.googlecode.com/hg/
10 years, 4 months ago (2014-11-14 11:51:20 UTC) #1
bradfitz
R=rsc (Russ doesn't read golang-codereviews anymore, and neither do most people, so be sure to ...
10 years, 4 months ago (2014-11-14 16:39:49 UTC) #2
rsc
LGTM
10 years, 4 months ago (2014-11-14 16:43:35 UTC) #3
jsing
10 years, 4 months ago (2014-11-14 16:55:26 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=3949acfe175a ***

[dev.cc] runtime: convert openbsd/386 port to Go

LGTM=rsc
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews
https://codereview.appspot.com/173200044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b