Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 172960043: [dev.cc] code review 172960043: cmd/dist: adjust for build process without cmd/cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
r
CC:
r, dave_cheney.net, austin, golang-codereviews, iant, khr
Visibility:
Public.

Description

cmd/dist: adjust for build process without cmd/cc [This CL is part of the removal of C code from package runtime. See golang.org/s/dev.cc for an overview.] - Remove references to C compiler directories. - Remove generation of special header files. - Remove generation of Go source files from C declarations. - Compile Go sources before rest of package (was after), so that Go compiler can write go_asm.h for use in assembly. - Move TLS information from cmd/dist (was embedding in output) to src/runtime/go_tls.h, which it can be maintained directly.

Patch Set 1 #

Patch Set 2 : diff -r 36ead9978fcc0be9de634236ad3887b41d9525e1 https://code.google.com/p/go #

Patch Set 3 : diff -r 36ead9978fcc0be9de634236ad3887b41d9525e1 https://code.google.com/p/go #

Patch Set 4 : diff -r c8eb721ef55280348ec52866d54ccafc30436417 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -408 lines) Patch
M src/cmd/dist/build.c View 1 2 3 15 chunks +46 lines, -94 lines 0 comments Download
M src/cmd/dist/buildruntime.c View 1 2 chunks +0 lines, -299 lines 0 comments Download
R src/runtime/defs.c View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
A src/runtime/go_tls.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: austin, golang-codereviews@googlegroups.com, iant, khr), I'd like you to review this change to ...
10 years, 7 months ago (2014-11-11 04:45:57 UTC) #1
r
LGTM
10 years, 7 months ago (2014-11-11 04:49:33 UTC) #2
dave_cheney.net
On 2014/11/11 04:49:33, r wrote: > LGTM LGT. line 575 of build.c, the comment is ...
10 years, 7 months ago (2014-11-11 05:48:23 UTC) #3
rsc
10 years, 7 months ago (2014-11-11 06:29:10 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=78d8a3352e27 ***

[dev.cc] cmd/dist: adjust for build process without cmd/cc

[This CL is part of the removal of C code from package runtime.
See golang.org/s/dev.cc for an overview.]

- Remove references to C compiler directories.
- Remove generation of special header files.
- Remove generation of Go source files from C declarations.

- Compile Go sources before rest of package (was after),
  so that Go compiler can write go_asm.h for use in assembly.

- Move TLS information from cmd/dist (was embedding in output)
  to src/runtime/go_tls.h, which it can be maintained directly.

LGTM=r
R=r, dave
CC=austin, golang-codereviews, iant, khr
https://codereview.appspot.com/172960043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b