Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 172410043: Add support for the manual provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by frankban
Modified:
9 years, 6 months ago
Reviewers:
rharding, mp+241595, matthew.scott
Visibility:
Public.

Description

Add support for the manual provider. Also reorder the provider fields so that required ones come first. The hope for this is to improve the user experience while creating environments. Tests: `make check`. QA: use quickstart as usual to set up environments. To test the manual provider, I've done the following: - I used a separate vmware virtual machine: let's assume its address is 192.168.1.5. - Install the SSH server in the vm: `sudo apt-get install ssh`. - Copy your ssh credential over: `scp -rp ~/.ssh 192.168.1.5:~`. - Allow sudo power without password for your user on the vm, by editing the /etc/sudoers file and adding the following: $USER ALL=(ALL) NOPASSWD: ALL where $USER is your user name. - Run `.venv/bin/python juju-quickstart -i`, select the option to create a new "Manual Provisioning" environment, select a name for it and use the vm address as the "bootstrap host", save the environment and then run it! - wait for the environment to be ready, then run quickstart again with the same environment to check it recognizes it's already bootstrapped. Done, thank you! https://code.launchpad.net/~frankban/juju-quickstart/manual-provider/+merge/241595 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add support for the manual provider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -76 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/models/envs.py View 16 chunks +100 lines, -44 lines 0 comments Download
M quickstart/tests/cli/test_views.py View 1 chunk +4 lines, -4 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 9 chunks +39 lines, -28 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
9 years, 6 months ago (2014-11-12 17:59:28 UTC) #1
rharding
LGTM and will QA. Ideally it would be cool if our QA instructions were using ...
9 years, 6 months ago (2014-11-12 22:08:24 UTC) #2
rharding
looks like the removal of provider storage won't be in 1.21 so ignore that hope ...
9 years, 6 months ago (2014-11-12 22:12:05 UTC) #3
rharding
QA: I used a digital ocean droplet - created droplet with my ssh key - ...
9 years, 6 months ago (2014-11-12 22:45:30 UTC) #4
matthew.scott
LGTM, no QA. THanks for this!
9 years, 6 months ago (2014-11-12 22:49:45 UTC) #5
frankban
Thanks for the reviews! https://codereview.appspot.com/172410043/diff/1/quickstart/models/envs.py File quickstart/models/envs.py (right): https://codereview.appspot.com/172410043/diff/1/quickstart/models/envs.py#newcode720 quickstart/models/envs.py:720: help='The host name of the ...
9 years, 6 months ago (2014-11-13 08:55:38 UTC) #6
frankban
9 years, 6 months ago (2014-11-13 08:57:26 UTC) #7
*** Submitted:

Add support for the manual provider.

Also reorder the provider fields so
that required ones come first.
The hope for this is to improve the
user experience while creating
environments.

Tests: `make check`.

QA: use quickstart as usual to set up
environments.
To test the manual provider, I've done
the following:

- I used a separate vmware virtual machine:
  let's assume its address is 192.168.1.5.
- Install the SSH server in the vm:
        `sudo apt-get install ssh`.
- Copy your ssh credential over:
        `scp -rp ~/.ssh 192.168.1.5:~`.
- Allow sudo power without password for your user on the vm, by
  editing the /etc/sudoers file and adding the following:
        $USER ALL=(ALL) NOPASSWD: ALL
  where $USER is your user name.
- Run `.venv/bin/python juju-quickstart -i`, select the option to
  create a new "Manual Provisioning" environment, select a name for it and
  use the vm address as the "bootstrap host", save the environment
  and then run it!
- wait for the environment to be ready, then run quickstart again
  with the same environment to check it recognizes it's
  already bootstrapped.
Done, thank you!

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/172410043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b