code review 171920043: go/buildutil: call ReadDir via the build.Context's file system interface

go/buildutil: call ReadDir via the build.Context's file system interface

[adonovan, 2014-11-05 17:15:31]

Hello gri@golang.org, crawshaw@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[gri, 2014-11-05 17:24:01]

LGTM

But please get rid of "virtualized" - it's a hyped buzzword and makes things
sound more complicated than they are.

https://codereview.appspot.com/171920043/diff/2/go/buildutil/allpackages.go
File go/buildutil/allpackages.go (right):

https://codereview.appspot.com/171920043/diff/2/go/buildutil/allpackages.go#n...
go/buildutil/allpackages.go:8: // All I/O is via the build.Context virtualized
file system, which must
s/is/is done/

https://codereview.appspot.com/171920043/diff/2/go/buildutil/allpackages.go#n...
go/buildutil/allpackages.go:8: // All I/O is via the build.Context virtualized
file system, which must
s/virtualized file system/file system interface/

"virtualized" is just the buzzword of the times, and has no concrete meaning in
Go. We don't have "virtual functions" - we have interfaces.

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go
File go/buildutil/util.go (right):

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode22
go/buildutil/util.go:22: // but uses the build context's virtual file system, if
any.
s/virtual file system/file system interface/

please replace everywhere

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode50
go/buildutil/util.go:50: // All I/O is via the build context's virtual file
system, if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode62
go/buildutil/util.go:62: // We must not assume the virtualized file tree uses
the file tree uses

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode67
go/buildutil/util.go:67: // virtualized paths will not use `\` unless the
PathSeparator
s/virtualized //

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode84
go/buildutil/util.go:84: // -- Effective methods of virtual file system
-------------------------
file system interface

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode91
go/buildutil/util.go:91: // using the build context's virtual file system.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode106
go/buildutil/util.go:106: // but uses the build context's virtual file system,
if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode115
go/buildutil/util.go:115: // but uses the build context's virtual file system,
if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode124
go/buildutil/util.go:124: // but uses the build context's virtual file system,
if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode133
go/buildutil/util.go:133: // but uses the build context's virtual file system,
if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode143
go/buildutil/util.go:143: // but uses the build context's virtual file system,
if any.
here

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode152
go/buildutil/util.go:152: // but uses the build context's virtual file system,
if any.
and here

[adonovan, 2014-11-05 17:32:25]

https://codereview.appspot.com/171920043/diff/2/go/buildutil/allpackages.go
File go/buildutil/allpackages.go (right):

https://codereview.appspot.com/171920043/diff/2/go/buildutil/allpackages.go#n...
go/buildutil/allpackages.go:8: // All I/O is via the build.Context virtualized
file system, which must
On 2014/11/05 17:24:00, gri wrote:
> s/virtualized file system/file system interface/
> 
> "virtualized" is just the buzzword of the times, and has no concrete meaning
in
> Go. We don't have "virtual functions" - we have interfaces.

Done.

But I'd never thought of the correspondence with virtual functions before;
"virtual file system" is a very widespread term for a file system interface that
is not implemented by the usual system calls.

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go
File go/buildutil/util.go (right):

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode22
go/buildutil/util.go:22: // but uses the build context's virtual file system, if
any.
On 2014/11/05 17:24:00, gri wrote:
> s/virtual file system/file system interface/
> 
> please replace everywhere
> 

Done.

https://codereview.appspot.com/171920043/diff/2/go/buildutil/util.go#newcode50
go/buildutil/util.go:50: // All I/O is via the build context's virtual file
system, if any.
On 2014/11/05 17:24:00, gri wrote:
> here

Done.

[adonovan, 2014-11-05 17:34:37]

*** Submitted as
https://code.google.com/p/go/source/detail?r=6fc790e5bfa6&repo=tools ***

go/buildutil: call ReadDir via the build.Context's file system interface

LGTM=gri
R=gri, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/171920043