Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 171560043: code review 171560043: regexp/syntax: Clarify comment of OpAnyCharNotNL.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by u
Modified:
10 years, 4 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

regexp/syntax: Clarify comment of OpAnyCharNotNL.

Patch Set 1 #

Patch Set 2 : diff -r d51282ff68c07a45b8523edc417359decdd1c45f https://code.google.com/p/go #

Patch Set 3 : diff -r d51282ff68c07a45b8523edc417359decdd1c45f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/regexp/syntax/regexp.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
u
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2014-11-12 02:08:31 UTC) #1
iant
LGTM
10 years, 4 months ago (2014-11-12 02:51:01 UTC) #2
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=7f69503551c3 *** regexp/syntax: Clarify comment of OpAnyCharNotNL. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/171560043 ...
10 years, 4 months ago (2014-11-12 02:52:20 UTC) #3
gobot
This CL appears to have broken the openbsd-amd64-rootbsd builder. See http://build.golang.org/log/0a8a5cd967399704dd6afbfd07552ffaea2b9bc2
10 years, 4 months ago (2014-11-12 02:55:12 UTC) #4
iant
10 years, 4 months ago (2014-11-12 02:56:28 UTC) #5
Nope.

error exporting repository: executing [hg archive -t files -r
7f69503551c30bff8245665f31a1e2bca15d2f80
/home/gopher/gobuilder/openbsd-amd64-rootbsd-7f69503551c3/go]: exit
status 255

On Tue, Nov 11, 2014 at 6:55 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the openbsd-amd64-rootbsd builder.
> See http://build.golang.org/log/0a8a5cd967399704dd6afbfd07552ffaea2b9bc2
>
> https://codereview.appspot.com/171560043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b