Issue 171560043: code review 171560043: regexp/syntax: Clarify comment of OpAnyCharNotNL.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 171560043: code review 171560043: regexp/syntax: Clarify comment of OpAnyCharNotNL.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by u

Modified:
10 years, 4 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

regexp/syntax: Clarify comment of OpAnyCharNotNL.

Patch Set 2 : diff -r d51282ff68c07a45b8523edc417359decdd1c45f https://code.google.com/p/go #

Patch Set 3 : diff -r d51282ff68c07a45b8523edc417359decdd1c45f https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/regexp/syntax/regexp.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2014-11-12 02:08:31 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=7f69503551c3 *** regexp/syntax: Clarify comment of OpAnyCharNotNL. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/171560043 ...

10 years, 4 months ago (2014-11-12 02:52:20 UTC) #3

gobot

This CL appears to have broken the openbsd-amd64-rootbsd builder. See http://build.golang.org/log/0a8a5cd967399704dd6afbfd07552ffaea2b9bc2

10 years, 4 months ago (2014-11-12 02:55:12 UTC) #4

iant

10 years, 4 months ago (2014-11-12 02:56:28 UTC) #5

Nope.

error exporting repository: executing [hg archive -t files -r
7f69503551c30bff8245665f31a1e2bca15d2f80
/home/gopher/gobuilder/openbsd-amd64-rootbsd-7f69503551c3/go]: exit
status 255

On Tue, Nov 11, 2014 at 6:55 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the openbsd-amd64-rootbsd builder.
> See http://build.golang.org/log/0a8a5cd967399704dd6afbfd07552ffaea2b9bc2
>
> https://codereview.appspot.com/171560043/

Expand All Messages | Collapse All Messages