http://codereview.appspot.com/1712046/diff/1/4 File blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java (right): http://codereview.appspot.com/1712046/diff/1/4#newcode72 blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72: Maintaining a set of test cases inclusively could be ...
13 years, 10 months ago
(2010-06-24 14:55:48 UTC)
#2
http://codereview.appspot.com/1712046/diff/1/4
File
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
(right):
http://codereview.appspot.com/1712046/diff/1/4#newcode72
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
Maintaining a set of test cases inclusively could be difficult in the future.
TestSuite.tests() already returns the list of all tests. Can we not copy them
over to a new TestSuite, and filter out a few excluded tests on the way? This
way we can keep the list of excluded test methods in the
BlackBerryDriverTestSuite, and get rid of testMethods.txt?
http://codereview.appspot.com/1712046/diff/1/4 File blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java (right): http://codereview.appspot.com/1712046/diff/1/4#newcode72 blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72: It seems JUnit test classes don't have valuable methods ...
13 years, 10 months ago
(2010-06-24 15:14:14 UTC)
#3
http://codereview.appspot.com/1712046/diff/1/4
File
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
(right):
http://codereview.appspot.com/1712046/diff/1/4#newcode72
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
It seems JUnit test classes don't have valuable methods that can be used for
filtering...
On 2010/06/24 14:55:48, baran wrote:
> Maintaining a set of test cases inclusively could be difficult in the future.
> TestSuite.tests() already returns the list of all tests. Can we not copy them
> over to a new TestSuite, and filter out a few excluded tests on the way? This
> way we can keep the list of excluded test methods in the
> BlackBerryDriverTestSuite, and get rid of testMethods.txt?
Is this feasible? (excuse sytax issues) List<String> excludeTests = new ArrayList<String>(); excludeTests.add("testIwontRunOnBlackberry"); excludeTests.add("testIwontRunOnBlackberryToo"); TestSuite originalSuite ...
13 years, 10 months ago
(2010-06-24 15:34:01 UTC)
#4
Is this feasible? (excuse sytax issues)
List<String> excludeTests = new ArrayList<String>();
excludeTests.add("testIwontRunOnBlackberry");
excludeTests.add("testIwontRunOnBlackberryToo"); TestSuite originalSuite =
new TestSuiteBuilder() .addSourceDir("common")
.addSourceDir("blackberry")
.usingDriver(TestBlackBerrySimulatorDriver.class)
.keepDriverInstance() .includeJavascriptTests()
.exclude(Driver.REMOTE).create();
TestSuite newSuite = new TestSuite() for (TestCase testCase : originalSuite)
{ if(!excludeTests.contains(testCase.getName()){
newSuite.addTestCase(testCase); } } return newSuite }
- Baran
On 24 June 2010 16:14, <shahun@google.com> wrote:
>
> http://codereview.appspot.com/1712046/diff/1/4
> File
>
> blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
> (right):
>
> http://codereview.appspot.com/1712046/diff/1/4#newcode72
>
>
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
>
> It seems JUnit test classes don't have valuable methods that can be used
> for filtering...
>
>
> On 2010/06/24 14:55:48, baran wrote:
>
>> Maintaining a set of test cases inclusively could be difficult in the
>>
> future.
>
>> TestSuite.tests() already returns the list of all tests. Can we not
>>
> copy them
>
>> over to a new TestSuite, and filter out a few excluded tests on the
>>
> way? This
>
>> way we can keep the list of excluded test methods in the
>> BlackBerryDriverTestSuite, and get rid of testMethods.txt?
>>
>
> http://codereview.appspot.com/1712046/show
>
- Baran On 24 June 2010 16:33, Baran ♪ <baran@google.com> wrote: > Is this feasible? ...
13 years, 10 months ago
(2010-06-24 15:38:45 UTC)
#5
- Baran
On 24 June 2010 16:33, Baran ♪ <baran@google.com> wrote:
> Is this feasible? (excuse sytax issues)
>
>
> List<String> excludeTests = new ArrayList<String>();
> excludeTests.add("testIwontRunOnBlackberry");
> excludeTests.add("testIwontRunOnBlackberryToo"); TestSuite originalSuite =
> new TestSuiteBuilder() .addSourceDir("common") .addSourceDir("blackberry")
> .usingDriver(TestBlackBerrySimulatorDriver.class) .keepDriverInstance()
.includeJavascriptTests()
> .exclude(Driver.REMOTE).create(); TestSuite newSuite = new TestSuite() for
> (TestCase testCase : originalSuite) {
>
Correction: for (TestCase testCase : originalSuite.tests()) {
> if(!excludeTests.contains(testCase.getName()){
> newSuite.addTestCase(testCase); } } return newSuite }
>
>
>
> - Baran
>
>
>
>
>
> On 24 June 2010 16:14, <shahun@google.com> wrote:
>
>>
>> http://codereview.appspot.com/1712046/diff/1/4
>> File
>>
>>
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
>> (right):
>>
>> http://codereview.appspot.com/1712046/diff/1/4#newcode72
>>
>>
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
>>
>> It seems JUnit test classes don't have valuable methods that can be used
>> for filtering...
>>
>>
>> On 2010/06/24 14:55:48, baran wrote:
>>
>>> Maintaining a set of test cases inclusively could be difficult in the
>>>
>> future.
>>
>>> TestSuite.tests() already returns the list of all tests. Can we not
>>>
>> copy them
>>
>>> over to a new TestSuite, and filter out a few excluded tests on the
>>>
>> way? This
>>
>>> way we can keep the list of excluded test methods in the
>>> BlackBerryDriverTestSuite, and get rid of testMethods.txt?
>>>
>>
>> http://codereview.appspot.com/1712046/show
>>
>
>
Perhaps I'm missing something here, but what's wrong with the @Ignore annotation? On 2010/06/24 15:38:45, ...
13 years, 10 months ago
(2010-06-27 12:29:49 UTC)
#7
Perhaps I'm missing something here, but what's wrong with the @Ignore
annotation?
On 2010/06/24 15:38:45, baran wrote:
> - Baran
>
>
>
>
> On 24 June 2010 16:33, Baran ♪ <mailto:baran@google.com> wrote:
>
> > Is this feasible? (excuse sytax issues)
> >
> >
> > List<String> excludeTests = new ArrayList<String>();
> > excludeTests.add("testIwontRunOnBlackberry");
> > excludeTests.add("testIwontRunOnBlackberryToo"); TestSuite originalSuite =
> > new TestSuiteBuilder() .addSourceDir("common") .addSourceDir("blackberry")
> > .usingDriver(TestBlackBerrySimulatorDriver.class) .keepDriverInstance()
> .includeJavascriptTests()
> > .exclude(Driver.REMOTE).create(); TestSuite newSuite = new TestSuite() for
> > (TestCase testCase : originalSuite) {
> >
> Correction: for (TestCase testCase : originalSuite.tests()) {
>
> > if(!excludeTests.contains(testCase.getName()){
> > newSuite.addTestCase(testCase); } } return newSuite }
> >
> >
> >
> > - Baran
> >
> >
> >
> >
> >
> > On 24 June 2010 16:14, <mailto:shahun@google.com> wrote:
> >
> >>
> >> http://codereview.appspot.com/1712046/diff/1/4
> >> File
> >>
> >>
> blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
> >> (right):
> >>
> >> http://codereview.appspot.com/1712046/diff/1/4#newcode72
> >>
> >>
>
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
> >>
> >> It seems JUnit test classes don't have valuable methods that can be used
> >> for filtering...
> >>
> >>
> >> On 2010/06/24 14:55:48, baran wrote:
> >>
> >>> Maintaining a set of test cases inclusively could be difficult in the
> >>>
> >> future.
> >>
> >>> TestSuite.tests() already returns the list of all tests. Can we not
> >>>
> >> copy them
> >>
> >>> over to a new TestSuite, and filter out a few excluded tests on the
> >>>
> >> way? This
> >>
> >>> way we can keep the list of excluded test methods in the
> >>> BlackBerryDriverTestSuite, and get rid of testMethods.txt?
> >>>
> >>
> >> http://codereview.appspot.com/1712046/show
> >>
> >
> >
>
It's because of Ignore.BLACKBERRY that isn't going to be merged into the Selenium trunk. Best ...
13 years, 10 months ago
(2010-06-28 08:23:50 UTC)
#8
It's because of Ignore.BLACKBERRY that isn't going to be merged into the
Selenium trunk.
Best regards,
Yauheni
On Sun, Jun 27, 2010 at 3:29 PM, <eranm@google.com> wrote:
> Perhaps I'm missing something here, but what's wrong with the @Ignore
> annotation?
>
> On 2010/06/24 15:38:45, baran wrote:
>
>> - Baran
>>
>
>
>
>
> On 24 June 2010 16:33, Baran ♪ <mailto:baran@google.com> wrote:
>>
>
> > Is this feasible? (excuse sytax issues)
>> >
>> >
>> > List<String> excludeTests = new ArrayList<String>();
>> > excludeTests.add("testIwontRunOnBlackberry");
>> > excludeTests.add("testIwontRunOnBlackberryToo"); TestSuite
>>
> originalSuite =
>
>> > new TestSuiteBuilder() .addSourceDir("common")
>>
> .addSourceDir("blackberry")
>
>> > .usingDriver(TestBlackBerrySimulatorDriver.class)
>>
> .keepDriverInstance()
>
>> .includeJavascriptTests()
>> > .exclude(Driver.REMOTE).create(); TestSuite newSuite = new
>>
> TestSuite() for
>
>> > (TestCase testCase : originalSuite) {
>> >
>> Correction: for (TestCase testCase : originalSuite.tests()) {
>>
>
> > if(!excludeTests.contains(testCase.getName()){
>> > newSuite.addTestCase(testCase); } } return newSuite }
>> >
>> >
>> >
>> > - Baran
>> >
>> >
>> >
>> >
>> >
>> > On 24 June 2010 16:14, <mailto:shahun@google.com> wrote:
>> >
>> >>
>> >> http://codereview.appspot.com/1712046/diff/1/4
>> >> File
>> >>
>> >>
>>
>
>
> blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java
>
>> >> (right):
>> >>
>> >> http://codereview.appspot.com/1712046/diff/1/4#newcode72
>> >>
>> >>
>>
>
>
>
blackberry/test/java/org/openqa/selenium/remote/BlackBerryDriverTestSuite.java:72:
>
>> >>
>> >> It seems JUnit test classes don't have valuable methods that can be
>>
> used
>
>> >> for filtering...
>> >>
>> >>
>> >> On 2010/06/24 14:55:48, baran wrote:
>> >>
>> >>> Maintaining a set of test cases inclusively could be difficult in
>>
> the
>
>> >>>
>> >> future.
>> >>
>> >>> TestSuite.tests() already returns the list of all tests. Can we
>>
> not
>
>> >>>
>> >> copy them
>> >>
>> >>> over to a new TestSuite, and filter out a few excluded tests on
>>
> the
>
>> >>>
>> >> way? This
>> >>
>> >>> way we can keep the list of excluded test methods in the
>> >>> BlackBerryDriverTestSuite, and get rid of testMethods.txt?
>> >>>
>> >>
>> >> http://codereview.appspot.com/1712046/show
>> >>
>> >
>> >
>>
>
>
>
>
> http://codereview.appspot.com/1712046/show
>
Issue 1712046: Wire protocol update. Unit test update. Workaround for handling list of test methods
Created 13 years, 10 months ago by shahun
Modified 13 years, 10 months ago
Reviewers: baran, Anatoli, Eran
Base URL: http://webdriver-blackberry.googlecode.com/svn/trunk/
Comments: 2
