Issue 171040043: Fix linking to last #msg in web UI.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 171040043: Fix linking to last #msg in web UI. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Dan Beam

Modified:
11 years, 7 months ago

Reviewers:
jrobbins (corp), jrobbins (chromium)

Visibility:
Public.

More Reviews

Description

Fix linking to last #msg in web UI. The message was being expanded by default and collapsed again when linked to via #msg<number>. BUG=510 R=maruel@chromium.org

Patch Set 1 : whoops #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	static/script.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	templates/issue.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jrobbins (corp)

11 years, 7 months ago (2014-11-06 19:33:35 UTC) #4

Committed as
https://code.google.com/p/rietveld/source/detail?r=9440d6cc0c05f52c8747f1a831...

And,
https://chromium.googlesource.com/infra/infra/+/e9ad3e79badb596f623841c6d3f47...

Expand All Messages | Collapse All Messages