Issue 170940044: code review 170940044: cmd/vet: update test patterns to include asm function name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 170940044: code review 170940044: cmd/vet: update test patterns to include asm function name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by austin

Modified:
10 years, 8 months ago

Reviewers:
r

CC:
adg, r, rsc, golang-codereviews

Visibility:
Public.

Description

cmd/vet: update test patterns to include asm function name vet now includes function names in its error messages about assembly code. Update the error test patterns to account for this and expand some patterns to check that go vet discovers the function name correctly. Fixes issue 9041

Patch Set 1 #

Patch Set 2 : diff -r fdf050fbab843cbe3f2b75cc3fe18621657df8de https://code.google.com/p/go.tools #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	cmd/vet/testdata/asm1.s	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	cmd/vet/testdata/asm2.s	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	cmd/vet/testdata/asm3.s	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

austin

Hello adg, r, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 8 months ago (2014-11-02 15:14:15 UTC) #1

austin

10 years, 8 months ago (2014-11-02 17:21:07 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=7e40432eea6b&repo=tools ***

cmd/vet: update test patterns to include asm function name

vet now includes function names in its error messages about
assembly code.  Update the error test patterns to account for
this and expand some patterns to check that go vet discovers
the function name correctly.

Fixes issue 9041

LGTM=r
R=adg, r, rsc
CC=golang-codereviews
https://codereview.appspot.com/170940044

Expand All Messages | Collapse All Messages