Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 170760043: Support for OS X 10.10 Yosemite and associated bugfixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by the80srobot
Modified:
2 years, 5 months ago
Reviewers:
scudette
CC:
rekall-dev_googlegroups.com
Base URL:
git@github.com:google/rekall.git@master
Visibility:
Public.

Description

Support for OS X 10.10 Yosemite and associated bugfixes. BUG= R=scudette@gmail.com Committed: 4c7e27e07dbcbbce71dfbd8f0b009d0137097cca

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes as per Michael's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -37 lines) Patch
M rekall/entities/component.py View 4 chunks +30 lines, -1 line 0 comments Download
M rekall/entities/definitions.py View 1 chunk +2 lines, -1 line 0 comments Download
M rekall/entities/entity.py View 3 chunks +23 lines, -9 lines 0 comments Download
M rekall/entities/identity.py View 1 chunk +8 lines, -1 line 0 comments Download
M rekall/entities/lookup_table.py View 2 chunks +15 lines, -0 lines 0 comments Download
M rekall/entities/manager.py View 3 chunks +4 lines, -5 lines 0 comments Download
M rekall/entities/query/analyzer.py View 1 chunk +1 line, -1 line 0 comments Download
M rekall/plugins/collectors/darwin/handles.py View 2 chunks +2 lines, -1 line 0 comments Download
M rekall/plugins/collectors/darwin/processes.py View 1 5 chunks +36 lines, -6 lines 0 comments Download
M rekall/plugins/collectors/darwin/sessions.py View 2 chunks +16 lines, -8 lines 0 comments Download
M rekall/plugins/collectors/events.py View 1 chunk +1 line, -1 line 0 comments Download
M rekall/plugins/overlays/basic.py View 1 3 chunks +11 lines, -0 lines 0 comments Download
M rekall/plugins/overlays/darwin/darwin.py View 1 chunk +1 line, -1 line 0 comments Download
M rekall/plugins/renderers/__init__.py View 1 chunk +2 lines, -2 lines 0 comments Download
A rekall/plugins/renderers/entities.py View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4
the80srobot
2 years, 5 months ago (2014-10-30 13:55:22 UTC) #1
scudette
LGTM https://codereview.appspot.com/170760043/diff/1/rekall/plugins/collectors/darwin/processes.py File rekall/plugins/collectors/darwin/processes.py (right): https://codereview.appspot.com/170760043/diff/1/rekall/plugins/collectors/darwin/processes.py#newcode261 rekall/plugins/collectors/darwin/processes.py:261: and len(unicode(proc.p_comm)) > 0 maybe add a __len__ ...
2 years, 5 months ago (2014-10-30 14:22:05 UTC) #2
the80srobot
2 years, 5 months ago (2014-10-30 22:26:58 UTC) #3
the80srobot
2 years, 5 months ago (2014-10-30 22:28:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 4c7e27e (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted