Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 170750043: code review 170750043: doc/go1.4.html: final library changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by r
Modified:
9 years, 5 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

doc/go1.4.html: final library changes First draft now complete.

Patch Set 1 #

Total comments: 10

Patch Set 2 : diff -r b3fb2d6e0e9948cff131b4e95dd103d5b62d5348 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -21 lines) Patch
M doc/go1.4.html View 1 4 chunks +129 lines, -21 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2014-10-29 20:36:50 UTC) #1
rsc
LGTM https://codereview.appspot.com/170750043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/170750043/diff/1/doc/go1.4.html#newcode564 doc/go1.4.html:564: so the split function can generate a final ...
9 years, 5 months ago (2014-10-29 21:55:35 UTC) #2
r
https://codereview.appspot.com/170750043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/170750043/diff/1/doc/go1.4.html#newcode564 doc/go1.4.html:564: so the split function can generate a final empty ...
9 years, 5 months ago (2014-10-29 22:34:59 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=3f6f728549d3 *** doc/go1.4.html: final library changes First draft now complete. LGTM=rsc R=golang-codereviews, ...
9 years, 5 months ago (2014-10-29 22:35:52 UTC) #4
gobot
9 years, 5 months ago (2014-10-29 22:44:47 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/59b31cffb4237b8572a3bff1b1aee0b4d994c05c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b