Copy or Update Stops with database only

[calidion, 2010-06-17 05:12:03]

Copy or Update Stops with database only

[weiliu, 2010-06-17 10:48:01]

codereview.appspot.com has DeadlineExceedError now, so please see my
comments as follows:

*470* def CopyStop(db, id, parentId, name, lat, lon):
Please add comments.

*476* if row and row[4]:
It's hard to understand the "if .., else ...", add comments, too.

*513* def ToStation(db, id):
Please make your comments clearer, for example, "upgrade a stop to station
by setting the location type to 1"?

On Thu, Jun 17, 2010 at 1:12 PM, <calidion@gmail.com> wrote:

> Reviewers: lychen, xan_google.com, weiliu, leio.chen, baiming,
>
> Message:
> Copy or Update Stops with database only
>
>
>
> Please review this at http://codereview.appspot.com/1706042/show
>
> Affected files:
>  MM    gtfsscheduleeditor/files/transit_editor.js
>  M     schedule_editor.py
>  M     transitfeed_editor.py
>
>
>


-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[calidion, 2010-06-18 01:39:04]

updated

[calidion, 2010-06-18 03:12:56]

先将就看一下不同吧


<    * Get StopTime object by stop
<    */
<   Trip.prototype.getStopTimeByStop = function(stop) {
<     for(var i = 0; i < this.stoptimes.length; i++) {
<       var stoptime = this.stoptimes[i];
<       if (stoptime.stop == stop) {
<         return stoptime;
<       }
<     }
<     return null;
<   }
<
<   /**
4067d4053
<     param['tid'] = act.obj.stoptime.trip.id;
4136,4137c4122,4124
<       var stoptime = Trip.current.getStopTimeByStop(this);
<       stoptime.onCopy();
---
>       this.triggerEvent('edit', {
>         cmd: 'copy'
>       });
4523a4511
>    * @param {Object} event Message from Stop
4525c4513
<   StopTime.prototype.onCopy = function() {
---
>   StopTime.prototype.onCopy = function(event) {


2010/6/18 <calidion@gmail.com>

> updated
>
>
> http://codereview.appspot.com/1706042/show
>

[weiliu, 2010-06-18 04:09:05]

Ming, take a look at the js change?

On Fri, Jun 18, 2010 at 11:12 AM, <李白> wrote:

> 先将就看一下不同吧
>
>
> <    * Get StopTime object by stop
> <    */
> <   Trip.prototype.getStopTimeByStop = function(stop) {
> <     for(var i = 0; i < this.stoptimes.length; i++) {
> <       var stoptime = this.stoptimes[i];
> <       if (stoptime.stop == stop) {
> <         return stoptime;
> <       }
> <     }
> <     return null;
> <   }
> <
> <   /**
> 4067d4053
> <     param['tid'] = act.obj.stoptime.trip.id;
> 4136,4137c4122,4124
>  <       var stoptime = Trip.current.getStopTimeByStop(this);
> <       stoptime.onCopy();
> ---
> >       this.triggerEvent('edit', {
> >         cmd: 'copy'
> >       });
> 4523a4511
> >    * @param {Object} event Message from Stop
> 4525c4513
> <   StopTime.prototype.onCopy = function() {
> ---
> >   StopTime.prototype.onCopy = function(event) {
>
>
> 2010/6/18 <calidion@gmail.com>
>
> updated
>>
>>
>> http://codereview.appspot.com/1706042/show
>>
>
>


-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[calidion, 2010-06-18 05:01:34]

Index: transit_editor.js
--- transit_editor.js 基本 (BASE)
+++ transit_editor.js 本地修改（基于 LOCAL）
@@ -1803,6 +1803,19 @@
   };

   /**
+   * Get StopTime object by stop
+   */
+  Trip.prototype.getStopTimeByStop = function(stop) {
+    for(var i = 0; i < this.stoptimes.length; i++) {
+      var stoptime = this.stoptimes[i];
+      if (stoptime.stop == stop) {
+        return stoptime;
+      }
+    }
+    return null;
+  }
+
+  /**
   * Return HTML to embed a SVG object in this page. src is the location of
   * the SVG and attributes is inserted directly into the object or embed
   * tag.
@@ -4051,6 +4064,7 @@
     var param = {};
     param['act'] = 'copy';
     param['parentId'] = parentId;
+    param['tid'] = act.obj.stoptime.trip.id;
     this.updateStop(param, this.onCopied, callback, act);
   };

@@ -4119,9 +4133,8 @@
    */
   Stop.prototype.onCopyNodeClick = function() {
     if (confirm('Sure to copy stop? New stop will be created.')) {
-      this.triggerEvent('edit', {
-        cmd: 'copy'
-      });
+      var stoptime = Trip.current.getStopTimeByStop(this);
+      stoptime.onCopy();
     }
   };

@@ -4508,9 +4521,8 @@

   /**
    * Handler for stop copy
-   * @param {Object} event Message from Stop
    */
-  StopTime.prototype.onCopy = function(event) {
+  StopTime.prototype.onCopy = function() {
     var stop = this.stop;

     var newStop = new Stop();
Index: transit_editor.js
--- transit_editor.js 基本 (BASE)
+++ transit_editor.js 本地修改（基于 LOCAL）


在 2010年6月18日 下午12:08，Wei Liu <weiliu@google.com>写道：

> Ming, take a look at the js change?
>
>
> On Fri, Jun 18, 2010 at 11:12 AM, <李白> wrote:
>
>> 先将就看一下不同吧
>>
>>
>> <    * Get StopTime object by stop
>> <    */
>> <   Trip.prototype.getStopTimeByStop = function(stop) {
>> <     for(var i = 0; i < this.stoptimes.length; i++) {
>> <       var stoptime = this.stoptimes[i];
>> <       if (stoptime.stop == stop) {
>> <         return stoptime;
>> <       }
>> <     }
>> <     return null;
>> <   }
>> <
>> <   /**
>> 4067d4053
>> <     param['tid'] = act.obj.stoptime.trip.id;
>> 4136,4137c4122,4124
>>  <       var stoptime = Trip.current.getStopTimeByStop(this);
>> <       stoptime.onCopy();
>> ---
>> >       this.triggerEvent('edit', {
>> >         cmd: 'copy'
>> >       });
>> 4523a4511
>> >    * @param {Object} event Message from Stop
>> 4525c4513
>> <   StopTime.prototype.onCopy = function() {
>> ---
>> >   StopTime.prototype.onCopy = function(event) {
>>
>>
>> 2010/6/18 <calidion@gmail.com>
>>
>> updated
>>>
>>>
>>> http://codereview.appspot.com/1706042/show
>>>
>>
>>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>