src/pkg/crypto/x509/x509.go - Issue 1704044: code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/crypto/x509/x509.go

Issue 1704044: code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in... (Closed)

Patch Set: code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in... Created 14 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/crypto/x509/x509.go

===================================================================

--- a/src/pkg/crypto/x509/x509.go

+++ b/src/pkg/crypto/x509/x509.go

@@ -407,8 +407,8 @@

return false

}

- patternParts := strings.Split(pattern, ".", 0)

- hostParts := strings.Split(host, ".", 0)

+ patternParts := strings.Split(pattern, ".", -1)

+ hostParts := strings.Split(host, ".", -1)

if len(patternParts) != len(hostParts) {

return false

« no previous file with comments | « src/pkg/bytes/bytes_test.go ('k') | src/pkg/exec/exec.go » ('j') | no next file with comments »