code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in...

src/pkg/crypto/x509/x509.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // This package parses X.509-encoded keys and certificates.
 package x509
 
 import (
         "asn1"
         "big"
@@ skipping 389 matching lines @@
         digest := h.Sum()
 
         return rsa.VerifyPKCS1v15(pub, hashType, digest, c.Signature)
 }
 
 func matchHostnames(pattern, host string) bool {
         if len(pattern) == 0 || len(host) == 0 {
                 return false
         }
 
-        patternParts := strings.Split(pattern, ".", 0)
-        hostParts := strings.Split(host, ".", 0)
+        patternParts := strings.Split(pattern, ".", -1)
+        hostParts := strings.Split(host, ".", -1)
 
         if len(patternParts) != len(hostParts) {
                 return false
         }
 
         for i, patternPart := range patternParts {
                 if patternPart == "*" {
                         continue
                 }
                 if patternPart != hostParts[i] {
@@ skipping 389 matching lines @@
                 return
         }
 
         cert, err = asn1.MarshalToMemory(certificate{
                 c,
                 algorithmIdentifier{oidSHA1WithRSA},
                 asn1.BitString{Bytes: signature, BitLength: len(signature) * 8},
         })
         return
 }