code review 1701048: Add syscall_bsd.go to zsycall_freebsd_386.go

Add syscall_bsd.go to zsycall_freebsd_386.go
Revision: 5885c9d10f created syscall_bsd.go for code used
by Darwin and other *BSDs, which should have included
FreeBSD. mksyscall.sh to generate new zsyscall_freebsd_386.go.
Fixes issue 862.

[peterGo, 2010-06-24 19:23:16]

Hello golang-dev@googlegroops.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg1, 2010-06-25 07:42:47]

LGTM

I have asked the 386/FreeBSD users in the thread to clpatch this in and confirm.

Have you submitted the CLA? I don't see you in CONTRIBUTORS.

Andrew

On 24 June 2010 20:23,  <go.peter.90@gmail.com> wrote:
> Reviewers: golang-dev_googlegroops.com,
>
> Message:
> Hello golang-dev@googlegroops.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> Add syscall_bsd.go to zsycall_freebsd_386.go
> Revision: 5885c9d10f created syscall_bsd.go for code used
> by Darwin and other *BSDs, which should have included
> FreeBSD. mksyscall.sh to generate new zsyscall_freebsd_386.go.
> Fixes issue 862.
>
> Please review this at http://codereview.appspot.com/1701048/show
>
> Affected files:
>  M src/pkg/syscall/zsyscall_freebsd_386.go
>
>
> Index: src/pkg/syscall/zsyscall_freebsd_386.go
> ===================================================================
> --- a/src/pkg/syscall/zsyscall_freebsd_386.go
> +++ b/src/pkg/syscall/zsyscall_freebsd_386.go
> @@ -1,4 +1,4 @@
> -// mksyscall.sh -l32 syscall_freebsd.go syscall_freebsd_386.go
> +// mksyscall.sh -l32 syscall_bsd.go syscall_freebsd.go
> syscall_freebsd_386.go
>  // MACHINE GENERATED BY THE COMMAND ABOVE; DO NOT EDIT
>
>  package syscall
> @@ -121,6 +121,18 @@
>        return
>  }
>
> +func utimes(path string, timeval *[2]Timeval) (errno int) {
> +       _, _, e1 := Syscall(SYS_UTIMES,
> uintptr(unsafe.Pointer(StringBytePtr(path))),
> uintptr(unsafe.Pointer(timeval)), 0)
> +       errno = int(e1)
> +       return
> +}
> +
> +func futimes(fd int, timeval *[2]Timeval) (errno int) {
> +       _, _, e1 := Syscall(SYS_FUTIMES, uintptr(fd),
> uintptr(unsafe.Pointer(timeval)), 0)
> +       errno = int(e1)
> +       return
> +}
> +
>  func fcntl(fd int, cmd int, arg int) (val int, errno int) {
>        r0, _, e1 := Syscall(SYS_FCNTL, uintptr(fd), uintptr(cmd),
> uintptr(arg))
>        val = int(r0)
>
>
>

[peterGo, 2010-06-26 09:11:48]

On 2010/06/25 07:42:47, adg1 wrote:

> Have you submitted the CLA? I don't see you in CONTRIBUTORS.

CLA submitted electronically on Friday morning.

Peter

[adg, 2010-06-28 23:11:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=020d5ec41470 ***

syscall: Add syscall_bsd.go to zsycall_freebsd_386.go

Revision: 5885c9d10f created syscall_bsd.go for code used
by Darwin and other *BSDs, which should have included
FreeBSD. mksyscall.sh to generate new zsyscall_freebsd_386.go.

Fixes issue 862.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/1701048

Committer: Andrew Gerrand <adg@golang.org>