Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 169590043: [dev.garbage] code review 169590043: all: merge default (f38460037b72) into dev.garbage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
austin
CC:
austin, golang-codereviews
Visibility:
Public.

Description

all: merge default (f38460037b72) into dev.garbage This is the revision that dev.cc is branched from.

Patch Set 1 #

Patch Set 2 : diff -r 7981f74109b66d905bf0731a22e6bbff3f7ea69f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7981f74109b66d905bf0731a22e6bbff3f7ea69f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7981f74109b66d905bf0731a22e6bbff3f7ea69f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1478 lines, -6291 lines) Patch
M .hgtags View 1 1 chunk +1 line, -0 lines 0 comments Download
M AUTHORS View 1 4 chunks +4 lines, -0 lines 0 comments Download
M CONTRIBUTORS View 1 4 chunks +4 lines, -0 lines 0 comments Download
M doc/articles/go_command.html View 1 1 chunk +7 lines, -6 lines 0 comments Download
M doc/cmd.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M doc/code.html View 1 12 chunks +95 lines, -86 lines 0 comments Download
M doc/contribute.html View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/go1.4.html View 1 11 chunks +292 lines, -55 lines 0 comments Download
M doc/go1compat.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M doc/go_faq.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M doc/install-source.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/codereview/codereview.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M misc/benchcmp View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/test/cgo_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M misc/cgo/test/issue6997_linux.go View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/test/issue9026.go View 1 1 chunk +9 lines, -0 lines 0 comments Download
M misc/cgo/test/issue9026/issue9026.go View 1 1 chunk +36 lines, -0 lines 0 comments Download
M misc/makerelease/makerelease.go View 1 2 chunks +5 lines, -5 lines 0 comments Download
R misc/pprof View 1 1 chunk +0 lines, -5100 lines 0 comments Download
M src/bufio/scan.go View 1 4 chunks +13 lines, -0 lines 0 comments Download
M src/bufio/scan_test.go View 1 1 chunk +67 lines, -0 lines 0 comments Download
M src/cmd/5g/reg.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/cgo/gcc.go View 1 3 chunks +15 lines, -9 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 chunks +0 lines, -9 lines 0 comments Download
M src/cmd/gc/lex.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/go/build.go View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/cmd/go/doc.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/go/generate.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/go/pkg.go View 1 3 chunks +18 lines, -6 lines 0 comments Download
M src/cmd/go/test.bash View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/cmd/go/tool.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/go/vet.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/internal/objfile/disasm.go View 1 1 chunk +248 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/elf.go View 1 2 chunks +25 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/goobj.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/macho.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/objfile.go View 1 3 chunks +23 lines, -1 line 0 comments Download
M src/cmd/internal/objfile/pe.go View 1 2 chunks +31 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/plan9obj.go View 1 2 chunks +22 lines, -0 lines 0 comments Download
R src/cmd/objdump/Makefile View 1 1 chunk +0 lines, -10 lines 0 comments Download
R src/cmd/objdump/elf.go View 1 1 chunk +0 lines, -65 lines 0 comments Download
R src/cmd/objdump/macho.go View 1 1 chunk +0 lines, -77 lines 0 comments Download
M src/cmd/objdump/main.go View 1 2 chunks +21 lines, -444 lines 0 comments Download
M src/cmd/objdump/objdump_test.go View 1 2 chunks +1 line, -99 lines 0 comments Download
R src/cmd/objdump/pe.go View 1 1 chunk +0 lines, -99 lines 0 comments Download
R src/cmd/objdump/plan9obj.go View 1 1 chunk +0 lines, -70 lines 0 comments Download
M src/cmd/pprof/README View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/cmd/pprof/doc.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/pprof/pprof.go View 1 3 chunks +38 lines, -3 lines 0 comments Download
M src/compress/lzw/reader.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crypto/crypto.go View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/database/sql/fakedb_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/database/sql/sql.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/debug/goobj/read_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/net/http/cookiejar/jar.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/net/http/main_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/net/http/serve_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/os/exec/exec_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/os/file_plan9.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/os/file_unix.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/os/file_windows.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/asm_386.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_arm.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/cgo/dragonfly.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/cgo/freebsd.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/cgo/netbsd.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/cgo/openbsd.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/crash_cgo_test.go View 1 2 chunks +27 lines, -2 lines 0 comments Download
M src/runtime/extern.go View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/runtime/heapdump.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/runtime/malloc.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/mgc0.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/mprof.go View 1 7 chunks +29 lines, -16 lines 0 comments Download
M src/runtime/os_android.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_plan9_386.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_plan9_amd64.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_windows_386.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_windows_amd64.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/proc.c View 1 6 chunks +11 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/runtime/sema.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/signal_386.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_amd64x.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_arm.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stack.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stubs.go View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/runtime/traceback.go View 1 4 chunks +44 lines, -9 lines 0 comments Download
M src/sync/atomic/value.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/issue7690.go View 1 1 chunk +49 lines, -0 lines 0 comments Download
M test/linkx.go View 1 2 chunks +4 lines, -10 lines 0 comments Download
M test/linkx_run.go View 1 1 chunk +33 lines, -0 lines 0 comments Download
M test/run.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/sinit.go View 1 6 chunks +46 lines, -31 lines 0 comments Download
M test/sinit_run.go View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 7 months ago (2014-11-14 15:33:07 UTC) #1
austin
LGTM
10 years, 7 months ago (2014-11-14 16:03:48 UTC) #2
rsc
10 years, 7 months ago (2014-11-14 16:38:01 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=c957f50feeba ***

[dev.garbage] all: merge default (f38460037b72) into dev.garbage

This is the revision that dev.cc is branched from.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/169590043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b