Issue 16940043: Remove bootstrap

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16940043: Remove bootstrap (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by huwshimi

Modified:
10 years, 6 months ago

Reviewers:
mp+192620, matthew.scott

Visibility:
Public.

Description

Remove bootstrap Bootstrap is gone. Updated classes to our new ones. Fixed styles that broke. I had to add normalize.css so that we have a reset (this is the reset that Bootstrap and YUI use). https://code.launchpad.net/~huwshimi/juju-gui/bootstrap-removal/+merge/192620 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove bootstrap #

Patch Set 3 : Remove bootstrap #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+707 lines, -5469 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
D	app/assets/stylesheets/bootstrap-2.0.4.css	View		1 chunk	+0 lines, -4983 lines	0 comments	Download
D	app/assets/stylesheets/juju-bootstrap.css	View		1 chunk	+0 lines, -156 lines	0 comments	Download
A	app/assets/stylesheets/normalize.css	View		1 chunk	+406 lines, -0 lines	0 comments	Download
M	app/index.html	View	1	1 chunk	+51 lines, -46 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	app/templates/ambiguousRelationList.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/bundle.handlebars	View	1	1 chunk	+2 lines, -8 lines	0 comments	Download
M	app/templates/notifications.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/token-container.handlebars	View		1 chunk	+3 lines, -8 lines	0 comments	Download
M	app/views/topology/relation.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/utils.js	View	1	3 chunks	+2 lines, -22 lines	0 comments	Download
M	bin/merge-files	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/views/browser/bws-searchbox.less	View		1 chunk	+2 lines, -6 lines	0 comments	Download
A	lib/views/dropdown.less	View		1 chunk	+62 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		4 chunks	+6 lines, -9 lines	0 comments	Download
M	lib/views/stylesheet.less	View		8 chunks	+161 lines, -210 lines	0 comments	Download
M	test/test_application_notifications.js	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	test/test_environment_view.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_utils.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

matthew.scott

LGTM, thanks https://codereview.appspot.com/16940043/diff/1/app/index.html File app/index.html (right): https://codereview.appspot.com/16940043/diff/1/app/index.html#newcode161 app/index.html:161: Help & Feedback Trivial: weird indentation https://codereview.appspot.com/16940043/diff/1/app/views/utils.js ...

10 years, 6 months ago (2013-10-25 01:00:56 UTC) #2

huwshimi

10 years, 6 months ago (2013-10-25 15:49:23 UTC) #4

*** Submitted:

Remove bootstrap

Bootstrap is gone. Updated classes to our new ones. Fixed styles that broke.

I had to add normalize.css so that we have a reset (this is the reset that
Bootstrap and YUI use).

R=matthew.scott
CC=
https://codereview.appspot.com/16940043

Expand All Messages | Collapse All Messages