Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(379)

Issue 169120043: [dev.garbage] code review 169120043: cmd/gc, runtime: add locks around print statements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
gobot, rlh
CC:
rlh, golang-codereviews
Visibility:
Public.

Description

cmd/gc, runtime: add locks around print statements Now each C printf, Go print, or Go println is guaranteed not to be interleaved with other calls of those functions. This should help when debugging concurrent failures.

Patch Set 1 #

Patch Set 2 : diff -r cec3f055c47e2123c243917bd738f9148d34b85d https://code.google.com/p/go/ #

Patch Set 3 : diff -r cec3f055c47e2123c243917bd738f9148d34b85d https://code.google.com/p/go/ #

Patch Set 4 : diff -r 515faabb8b4beef7f5aa924199e5036f4cc35fc7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -71 lines) Patch
M src/cmd/gc/builtin.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 3 chunks +17 lines, -0 lines 0 comments Download
M src/runtime/print1.go View 1 2 3 chunks +27 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/live.go View 1 2 3 24 chunks +86 lines, -66 lines 0 comments Download
M test/live2.go View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 4 months ago (2014-11-05 19:24:48 UTC) #1
rlh
LGTM
10 years, 4 months ago (2014-11-05 19:29:10 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=7bcd3f25a2a3 *** [dev.garbage] cmd/gc, runtime: add locks around print statements Now each ...
10 years, 4 months ago (2014-11-05 19:42:59 UTC) #3
gobot
10 years, 4 months ago (2014-11-08 01:30:41 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-luitvd builder.
See http://build.golang.org/log/3eb9177bced505ab10d72b7acc017b718031b12b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b