A good start, see the comments below. Also, this patch should remove unneeded files such ...
14 years, 4 months ago
(2009-12-09 15:33:56 UTC)
#1
A good start, see the comments below. Also, this patch should remove unneeded
files such as python3/setup.py, and also update the Makefile release: target.
Thanks!
http://codereview.appspot.com/169043/diff/1/5
File setup.py (right):
http://codereview.appspot.com/169043/diff/1/5#newcode59
setup.py:59: package_dir=pkgdir,
A good start, but when you build the distribution packages, only the python2
package or python3 files get added, depending on which version of python you run
`python setup.py sdist --formats=gztar,zip` with.
On 2009/12/09 15:33:56, jcgregorio wrote: > A good start, see the comments below. Also, this ...
14 years, 4 months ago
(2009-12-09 15:45:44 UTC)
#2
On 2009/12/09 15:33:56, jcgregorio wrote:
> A good start, see the comments below. Also, this patch should remove unneeded
> files such as python3/setup.py, and also update the Makefile release: target.
> Thanks!
I don't have a python3/setup.py in the repository. Do you mean python3/README?
On 2009/12/09 15:33:56, jcgregorio wrote: > A good start, see the comments below. Also, this ...
14 years, 4 months ago
(2009-12-09 15:53:30 UTC)
#3
On 2009/12/09 15:33:56, jcgregorio wrote:
> A good start, see the comments below. Also, this patch should remove unneeded
> files such as python3/setup.py, and also update the Makefile release: target.
> Thanks!
I don't have a python3/setup.py in the repository. Do you mean python3/README?
My bad, there should be a python3/setup.py, the one I used to build the last ...
14 years, 4 months ago
(2009-12-09 16:07:59 UTC)
#4
My bad, there should be a python3/setup.py, the one I used to build the last
release, but it never got checked into the repository.
But now that you mention it, the README files should be merged.
Issue 169043: Select version at install time
Created 14 years, 4 months ago by djc
Modified 9 years, 7 months ago
Reviewers: jcgregorio
Base URL:
Comments: 1