Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 168950044: [dev.power64] code review 168950044: all: merge default into dev.power64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by austin
Modified:
10 years, 7 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

all: merge default into dev.power64 Trivial merge except for src/runtime/asm_power64x.s and src/runtime/signal_power64x.c

Patch Set 1 #

Patch Set 2 : diff -r 1684ccd6fa7919e4b7be306cd01f5f6115a37f16 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -663 lines) Patch
M .hgtags View 1 chunk +1 line, -0 lines 0 comments Download
M AUTHORS View 4 chunks +4 lines, -0 lines 0 comments Download
M CONTRIBUTORS View 4 chunks +4 lines, -0 lines 0 comments Download
M doc/go1.4.html View 7 chunks +265 lines, -45 lines 0 comments Download
M misc/cgo/test/cgo_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M misc/cgo/test/issue6997_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/test/issue9026.go View 1 chunk +33 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 3 chunks +15 lines, -9 lines 0 comments Download
M src/cmd/go/doc.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/go/generate.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/internal/objfile/elf.go View 2 chunks +25 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/goobj.go View 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/macho.go View 1 chunk +24 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/objfile.go View 2 chunks +10 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/pe.go View 2 chunks +31 lines, -0 lines 0 comments Download
M src/cmd/internal/objfile/plan9obj.go View 2 chunks +22 lines, -0 lines 0 comments Download
R src/cmd/objdump/Makefile View 1 chunk +0 lines, -10 lines 0 comments Download
R src/cmd/objdump/elf.go View 1 chunk +0 lines, -65 lines 0 comments Download
R src/cmd/objdump/macho.go View 1 chunk +0 lines, -77 lines 0 comments Download
M src/cmd/objdump/main.go View 6 chunks +30 lines, -247 lines 0 comments Download
M src/cmd/objdump/objdump_test.go View 1 chunk +1 line, -1 line 0 comments Download
R src/cmd/objdump/pe.go View 1 chunk +0 lines, -99 lines 0 comments Download
R src/cmd/objdump/plan9obj.go View 1 chunk +0 lines, -70 lines 0 comments Download
M src/database/sql/fakedb_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M src/database/sql/sql.go View 1 chunk +5 lines, -0 lines 0 comments Download
M src/net/http/main_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/asm_386.s View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_arm.s View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/asm_power64x.s View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/crash_cgo_test.go View 2 chunks +27 lines, -2 lines 0 comments Download
M src/runtime/extern.go View 1 chunk +10 lines, -1 line 0 comments Download
M src/runtime/heapdump.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/mgc0.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/mprof.go View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_plan9_386.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_plan9_amd64.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_windows_386.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/os_windows_amd64.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/proc.c View 4 chunks +6 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/runtime/signal_386.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_amd64x.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_arm.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/signal_power64x.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/stack.c View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/traceback.go View 4 chunks +24 lines, -9 lines 0 comments Download
M src/sync/atomic/value.go View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/issue7690.go View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4
austin
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
10 years, 7 months ago (2014-11-03 15:31:02 UTC) #1
rsc
LGTM
10 years, 7 months ago (2014-11-03 15:44:55 UTC) #2
austin
*** Submitted as https://code.google.com/p/go/source/detail?r=79c94d0f64fe *** [dev.power64] all: merge default into dev.power64 Trivial merge except for ...
10 years, 7 months ago (2014-11-03 15:53:19 UTC) #3
gobot
10 years, 7 months ago (2014-11-03 16:00:00 UTC) #4
Message was sent while issue was closed. 
This CL appears to have broken the freebsd-amd64 builder.
See http://build.golang.org/log/402a4ac4317d81f85825436a8368d1a410631bdc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b