Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

Issue 168890043: code review 168890043: doc: document go get -f flag in 1.4 release notes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by adg
Modified:
9 years, 6 months ago
Reviewers:
r, gobot, rsc
CC:
r, rsc, adg1, golang-codereviews
Visibility:
Public.

Description

doc: document go get -f flag in 1.4 release notes

Patch Set 1 #

Total comments: 8

Patch Set 2 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 3 : diff -r 53ebc70d4e9f843cb718f173e3225e9a0fc121e2 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M doc/go1.4.html View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello r, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-10-31 00:04:35 UTC) #1
r
https://codereview.appspot.com/168890043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/168890043/diff/1/doc/go1.4.html#newcode364 doc/go1.4.html:364: refuse to compile a package that imports <code>"github.com/rsc/pdf"</code>, stet. ...
9 years, 6 months ago (2014-10-31 01:29:50 UTC) #2
adg1
PTAL https://codereview.appspot.com/168890043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/168890043/diff/1/doc/go1.4.html#newcode364 doc/go1.4.html:364: refuse to compile a package that imports <code>"github.com/rsc/pdf"</code>, ...
9 years, 6 months ago (2014-10-31 03:26:03 UTC) #3
r
LGTM
9 years, 6 months ago (2014-10-31 05:53:51 UTC) #4
rsc
Lgtm but s/vanity/custom/. Anywhere else that says vanity should change too but I don't know ...
9 years, 6 months ago (2014-10-31 13:54:20 UTC) #5
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=4748d80fbc2a *** doc: document go get -f flag in 1.4 release notes ...
9 years, 6 months ago (2014-11-03 06:01:27 UTC) #6
gobot
9 years, 6 months ago (2014-11-03 16:15:47 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/d163475125f787201a6fe0275a663c912636b462
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b