Enhancements to org.apache.shindig.gadgets.AbstractSpecFactory$Query

This patch makes the following enhancements to org.apache.shindig.gadgets.AbstractSpecFactory$Query:

1. Changes the visibility of all existing fields from private to protected, for easier subclassing.

2. Adds a field of type GadgetContext, along with corresponding setter and getter methods.

The latter would make it possible to embed the GadgetContext passed to GadgetSpecFactory#getGadgetSpec into the Query object that is generated as part of this call and passed to AbstractSpecFactory#getSpec(Query).

As a result of this, AbstractSpecFactory#parse(String, Query) would now be able to retrieve the GadgetContext from the Query argument, and from the GadgetContext, things like the Locale.

[janluehe, 2010-06-23 19:22:23]

I realize that adding getter and setter methods for GadgetContext to Query will
introduce some duplication, because Query already contains specUri, container,
gadgetUri, and ignoreCache fields, which are also available from GadgetContext
(but we want those fields to be individually settable on Query, and there may
not always be a GadgetContext available when the Query object is initialized, as
is the case when initializing a LocaleQuery in
DefaultMessageBundleFactory#getBundleFor). 

How about adding setter and getter methods for Locale and SecurityToken to
Query?

[janluehe, 2010-06-23 19:24:18]

Another version of the patch that adds Query setter and getter methods for
Locale and SecurityToken

[janluehe, 2010-06-23 19:41:15]

Just to clarify: We currently extend Query by adding Locale and SecurityToken
fields to it, which we initialize from GadgetContext.

We require access to those fields when parsing the gadget spec that is being
queried. 

So the proposal is to either make the entire GadgetContext available from the
Query (which would introduce some duplication as explained earlier), or just the
Locale and SecurityToken of the original gadget request.


On 2010/06/23 19:22:23, janluehe wrote:
> I realize that adding getter and setter methods for GadgetContext to Query
will
> introduce some duplication, because Query already contains specUri, container,
> gadgetUri, and ignoreCache fields, which are also available from GadgetContext
> (but we want those fields to be individually settable on Query, and there may
> not always be a GadgetContext available when the Query object is initialized,
as
> is the case when initializing a LocaleQuery in
> DefaultMessageBundleFactory#getBundleFor). 
> 
> How about adding setter and getter methods for Locale and SecurityToken to
> Query?

[janluehe, 2010-06-24 01:28:20]

Renamed LocaleQuery#locale to LocaleQuery#localeSpec so that it does not mask
new Query#locale

[Paul Lindner, 2010-06-24 19:50:01]

Something odd is going on here..  It appears that fetches are cached by their
specUri however the rewrite and fetch use params from Query to vary their
output...