code review 168710043: runtime: GOARCH values for ppc64 BE & LE

runtime: GOARCH values for ppc64 BE & LE

ppc64 for BE
ppc64le for LE
issue 8654

configure needs to be regenerated

[laboger, 2014-11-14 13:44:36]

Hello iant@golang.org, gofrontend-dev@googlegroups.com (cc:
gofrontend-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/gofrontend/

[iant, 2014-11-14 17:21:32]

https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac
File libgo/configure.ac (right):

https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...
libgo/configure.ac:271: [AC_COMPILE_IFELSE([
You don't need to use AC_COMPILE_IFELSE here.  You can write

  if test $ac_cv_c_bigendian = "yes"; then
    GOARCH=power64
  else
    GOARCH=power64le
  fi

https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...
libgo/configure.ac:279: GOARCH=ppc64
Let's change to "power64" and "power64le".

I'm not sure if the 32-bit version should use "power32" or plain "power". 
Probably "power32" would be best at this point.

[laboger, 2014-11-19 21:03:33]

I tried the change to use ac_cv_c_bigendian but the variable is not set 
until later in the configure file so the value was not available at the 
time GOARCH was being set.

I don't want to make a bigger change to move code around for this.  Unless 
there is some simple way to make this work I'd prefer to leave it as is.

This also requires a change to gcc/testsuite/go.test/go-test.exp to avoid 1 
testcase failure in the go testsuite on ppc64le.  
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02489.html

On Friday, November 14, 2014 11:21:32 AM UTC-6, Ian Lance Taylor wrote:
>
>
> https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac 
> File libgo/configure.ac (right): 
>
>
https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...

>
> libgo/configure.ac:271 
>
<https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...>:

> [AC_COMPILE_IFELSE([ 
> You don't need to use AC_COMPILE_IFELSE here.  You can write 
>
>    if test $ac_cv_c_bigendian = "yes"; then 
>      GOARCH=power64 
>    else 
>      GOARCH=power64le 
>    fi 
>
>
https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...

>
> libgo/configure.ac:279 
>
<https://codereview.appspot.com/168710043/diff/40001/libgo/configure.ac#newcod...>:

> GOARCH=ppc64 
> Let's change to "power64" and "power64le". 
>
> I'm not sure if the 32-bit version should use "power32" or plain 
> "power".  Probably "power32" would be best at this point. 
>
> https://codereview.appspot.com/168710043/ 
>

[iant, 2014-11-21 18:01:42]

LGTM

Thanks.

[iant, 2014-11-21 18:21:37]

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=547a3bf5788a ***

runtime: GOARCH values for ppc64 BE & LE

ppc64 for BE
ppc64le for LE
issue 8654

configure needs to be regenerated

LGTM=iant
R=iant, gofrontend-dev
CC=gofrontend-dev
https://codereview.appspot.com/168710043

Committer: Ian Lance Taylor <iant@golang.org>