Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6400)

Issue 1686055: Eval,unresolved variables, and other minor changes in chapter 12 tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by pedro.delgallego
Modified:
13 years, 8 months ago
Base URL:
http://sputniktests.googlecode.com/svn/trunk/tests/Conformance/12_Statement/
Visibility:
Public.

Description

Many of the Test from Chapter 12 of the specification are not runnable in ECMAScript 5. 1) I eliminate the unresolved variables 2) In S12.2_A11 add dot notation to the test 3) In S12.5_A5 add information about the Exception that has been launch.

Patch Set 1 #

Patch Set 2 : update S12.2_A11.js, S12.5_A5.js, and S12.6.1_A2.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -94 lines) Patch
M 12.11_The_switch_Statement/S12.11_A1_T2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.1_Block/S12.1_A4_T1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.1_Block/S12.1_A4_T2.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.2_Variable_Statement/S12.2_A11.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
M 12.2_Variable_Statement/S12.2_A2.js View 1 chunk +1 line, -0 lines 0 comments Download
M 12.2_Variable_Statement/S12.2_A9.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.4_Expression_Statement/S12.4_A2_T1.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.4_Expression_Statement/S12.4_A2_T2.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.5_The_if_Statement/S12.5_A10_T1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.5_The_if_Statement/S12.5_A5.js View 1 2 chunks +8 lines, -4 lines 0 comments Download
M 12.5_The_if_Statement/S12.5_A7.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A1.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A2.js View 1 1 chunk +6 lines, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A3.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A4_T1.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A5.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A8.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A4_T1.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A5.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A7.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A8.js View 1 2 chunks +1 line, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A10.js View 1 1 chunk +10 lines, -10 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A10.1.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T2.js View 1 2 chunks +1 line, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T1.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T2.js View 1 3 chunks +5 lines, -5 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T1.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T2.js View 1 3 chunks +7 lines, -7 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A3.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A5.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A9.1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A14_T2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A5.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A5.1.js View 1 1 chunk +2 lines, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A6.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A6.1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A7_T1.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M 12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A7_T2.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M 12.9_The_return_Statement/S12.9_A3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M 12.9_The_return_Statement/S12.9_A4.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
pedro.delgallego
13 years, 9 months ago (2010-07-16 16:29:42 UTC) #1
christian.plesner.hansen
> 12.2_Variable_Statement/S12.2_A11.js Consider adding a CHECK #5 at the end that tests that __another_var also ...
13 years, 8 months ago (2010-08-08 02:52:42 UTC) #2
Jasvir
LGTM Codereview broken for this change. Misspelt "balloon" in A2 and "expression" in A5.
13 years, 8 months ago (2010-08-19 22:07:02 UTC) #3
pedro.delgallego
On 2010/08/19 22:07:02, jasvir wrote: > LGTM > > Codereview broken for this change. > ...
13 years, 8 months ago (2010-08-20 00:12:08 UTC) #4
christian.plesner.hansen
Can you upload a new patch set containing the fixes? On 2010/08/20 00:12:08, pedro.delgallego wrote: ...
13 years, 8 months ago (2010-08-25 04:27:32 UTC) #5
christian.plesner.hansen
I see that has already been submitted. Nevermind then. On 2010/08/25 04:27:32, christian.plesner.hansen wrote: > ...
13 years, 8 months ago (2010-08-25 04:29:36 UTC) #6
pedro.delgallego
13 years, 8 months ago (2010-08-30 10:19:47 UTC) #7
On 2010/08/25 04:29:36, christian.plesner.hansen wrote:
> I see that has already been submitted.  Nevermind then.

I fixed the tests (S12.2_A11, S12.5_A5, S12.6.1_A2) as you suggested. 

I also mark test S12.2_A2.js as strict_mode_negative.

You can check the change in the new patch set.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b