code review 1686047: io/ioutil.TempFile for Windows

io/ioutil.TempFile for Windows
Fixes issue 834

[peterGo, 2010-06-30 08:46:59]

Hello rsc, brainman (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[brainman, 2010-06-30 12:01:23]

LGTM

[rsc, 2010-06-30 15:43:43]

Let's rename os.TempDirPath to just os.TempDir.

[peterGo, 2010-06-30 17:00:44]

Hello rsc, brainman (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-30 19:37:19]

few comment nits.  thanks again.

http://codereview.appspot.com/1686047/diff/7001/8001
File src/pkg/io/ioutil/tempfile.go (right):

http://codereview.appspot.com/1686047/diff/7001/8001#newcode37
src/pkg/io/ioutil/tempfile.go:37: // for temporary files.  Multiple programs
calling TempFile
sorry, one more nit.

// If dir is the empty string, TempFile uses the default directory
// for temporary files (see os.TempDir).

then please put the rest of the comment back as it was
(no need to reflow, and better to start new sentences
on new lines for fast scanning of text output anyway).

http://codereview.appspot.com/1686047/diff/7001/8004
File src/pkg/os/env_unix.go (right):

http://codereview.appspot.com/1686047/diff/7001/8004#newcode9
src/pkg/os/env_unix.go:9: // TempDir retrieves the path of the default directory
for temporary
godoc doesn't know which comment to use in general.
for now, let's merge the comments into one.

// TempDir returns the default directory to use for temporary files.
// On Unix-like systems, it uses the environment variable $TMPDIR
// or, if that is empty, /tmp.
// On Windows systems, it uses the Windows GetTempPath API.

http://codereview.appspot.com/1686047/diff/7001/8005
File src/pkg/os/env_windows.go (right):

http://codereview.appspot.com/1686047/diff/7001/8005#newcode14
src/pkg/os/env_windows.go:14: // TempDir retrieves the path of the default
directory for temporary
delete doc comment (see other file)

[peterGo, 2010-06-30 20:24:20]

Hello rsc, brainman (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-30 20:31:25]

LGTM

thanks

[rsc, 2010-06-30 20:37:11]

I changed the line in tempfile_test.go to say

	re := testing.MustCompile("^" + regexp.QuoteMeta(dir) + "/ioutil_test[0-9]+$")

(added QuoteMeta) so that if $TMPDIR has a + in it,
the regexp doesn't fail.  You may want to just revert
that file (hg revert) before running hg sync.  Otherwise
you'll have a merge conflict.

Sorry for the trouble; I have no idea why my $TMPDIR
is so weird.

Russ

[rsc, 2010-06-30 20:52:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=87c436111c30 ***

io/ioutil.TempFile for Windows
Fixes issue 834.

R=rsc, brainman
CC=golang-dev
http://codereview.appspot.com/1686047

Committer: Russ Cox <rsc@golang.org>