Issue 168590043: [dev.cc] code review 168590043: runtime: convert freebsd to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 168590043: [dev.cc] code review 168590043: runtime: convert freebsd to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rsc

Modified:
10 years, 7 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

runtime: convert freebsd to Go It builds. Don't know if it works, but it's a lot closer than having everything in C.

Patch Set 1 #

Patch Set 2 : diff -r 7ebad090f4f1bb6bc2645a310acfdf0060fd4c99 https://code.google.com/p/go #

Patch Set 3 : diff -r 7ebad090f4f1bb6bc2645a310acfdf0060fd4c99 https://code.google.com/p/go #

Patch Set 4 : diff -r 7ebad090f4f1bb6bc2645a310acfdf0060fd4c99 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+535 lines, -904 lines)			Patch
A	src/runtime/cputicks.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/runtime/defs_freebsd_386.go	View	1	4 chunks	+48 lines, -40 lines	0 comments	Download
M	src/runtime/defs_freebsd_amd64.go	View	1	4 chunks	+50 lines, -42 lines	0 comments	Download
M	src/runtime/defs_freebsd_arm.go	View	1	4 chunks	+18 lines, -10 lines	0 comments	Download
M	src/runtime/mem_bsd.go	View	1	1 chunk	+58 lines, -70 lines	0 comments	Download
R	src/runtime/mem_dragonfly.c	View	1	1 chunk	+0 lines, -105 lines	0 comments	Download
R	src/runtime/mem_netbsd.c	View	1	1 chunk	+0 lines, -100 lines	0 comments	Download
R	src/runtime/mem_openbsd.c	View	1	1 chunk	+0 lines, -100 lines	0 comments	Download
M	src/runtime/os1_freebsd.go	View	1	1 chunk	+168 lines, -267 lines	0 comments	Download
M	src/runtime/os2_freebsd.go	View	1	1 chunk	+7 lines, -24 lines	0 comments	Download
M	src/runtime/os_darwin.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/runtime/os_freebsd.go	View	1	1 chunk	+23 lines, -6 lines	0 comments	Download
M	src/runtime/os_freebsd_arm.go	View	1	1 chunk	+5 lines, -12 lines	0 comments	Download
M	src/runtime/os_linux_386.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
R	src/runtime/os_linux_amd64.go	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/runtime/signal_freebsd.go	View	1	1 chunk	+40 lines, -48 lines	0 comments	Download
M	src/runtime/signal_freebsd_386.go	View	1	1 chunk	+27 lines, -16 lines	0 comments	Download
M	src/runtime/signal_freebsd_amd64.go	View	1	1 chunk	+37 lines, -24 lines	0 comments	Download
M	src/runtime/signal_freebsd_arm.go	View	1	1 chunk	+43 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...

10 years, 7 months ago (2014-11-12 03:49:16 UTC) #1

rsc

10 years, 7 months ago (2014-11-12 04:00:34 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e95ad32f0369 ***

[dev.cc] runtime: convert freebsd to Go

It builds.
Don't know if it works, but it's a lot closer than having everything in C.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/168590043

Expand All Messages | Collapse All Messages