code review 168250043: doc: change "/s/..." links to be on golang.org

doc: change "/s/..." links to be on golang.org

People viewing this locally will not have a /s/ on their local godoc.
tip.golang.org doesn't have one either.

Also change all golang.org links to https, to avoid mixed content
warnings when viewing https://golang.org/.

Fixes issue 9028.

[rsc, 2014-11-06 14:46:43]

Hello r (cc: adg, golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-11-06 15:00:47]

Links don't trigger mixed content warnings, do they?

Why not protocol-relative links? "//golang.org /foo"

On Thursday, November 6, 2014, <rsc@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: adg, golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> doc: change "/s/..." links to be on golang.org
>
> People viewing this locally will not have a /s/ on their local godoc.
> tip.golang.org doesn't have one either.
>
> Also change all golang.org links to https, to avoid mixed content
> warnings when viewing https://golang.org/.
>
> Fixes issue 9028.
>
> Please review this at https://codereview.appspot.com/168250043/
>
> Affected files (+8, -8 lines):
>   M doc/go1.4.html
>
>
> Index: doc/go1.4.html
> ===================================================================
> --- a/doc/go1.4.html
> +++ b/doc/go1.4.html
> @@ -120,9 +120,9 @@
>  <p>
>  Go 1.4 can build binaries for ARM processors running the Android
> operating system.
>  It can also build a <code>.so</code> library that can be loaded by an
> Android application
> -using the supporting packages in the <a
href="http://golang.org/x/mobile">mobile</a>
> subrepository.
> +using the supporting packages in the <a
href="https://golang.org/x/mobile">mobile</a>
> subrepository.
>  A brief description of the plans for this experimental port are available
> -<a href="/s/go14android">here</a>.
> +<a href="//golang.org/s/go14android">here</a>.
>  </p>
>
>  <h3 id="naclarm">NaCl on ARM</h3>
> @@ -193,7 +193,7 @@
>  When a stack limit is reached, a new, larger stack is allocated, all
> active frames for
>  the goroutine are copied there, and any pointers into the stack are
> updated.
>  Performance can be noticeably better in some cases and is always more
> predictable.
> -Details are available in <a href="/s/contigstacks">the design
> document</a>.
> +Details are available in <a href="https://golang.org/s/contigstacks">the
> design document</a>.
>  </p>
>
>  <p>
> @@ -320,7 +320,7 @@
>
>  <p>
>  Full details of the mechanism are in
> -<a href="http://golang.org/s/go14internal">the design document</a>.
> +<a href="https://golang.org/s/go14internal">the design document</a>.
>  </p>
>
>  <h3 id="canonicalimports">Canonical import paths</h3>
> @@ -382,7 +382,7 @@
>
>  <p>
>  Further information is in
> -<a href="http://golang.org/s/go14customimport">the design document</a>.
> +<a href="https://golang.org/s/go14customimport">the design document</a>.
>  </p>
>
>  <h3 id="subrepo">Import paths for the subrepositories</h3>
> @@ -418,7 +418,7 @@
>
>  <p>
>  For more information, see the
> -<a href="http://golang.org/s/go1.4-generate">design document</a>.
> +<a href="https://golang.org/s/go1.4-generate">design document</a>.
>  </p>
>
>  <h3 id="filenames">Change to file name handling</h3>
> @@ -604,12 +604,12 @@
>  for changes needed to maintain the core repository.
>  In particular, it will no longer be extended to support new or different
> system calls
>  that are not used by the core.
> -The reasons are described at length in <a href="http://golang.org/s/go1.
> 4-syscall">a
> +The reasons are described at length in <a href="https://golang.org/s/
> go1.4-syscall">a
>  separate document</a>.
>  </p>
>
>  <p>
> -A new subrepository, <a href="http://golang.org/x/sys">golang.org/x/sys
> </a>,
> +A new subrepository, <a href="https://golang.org/x/sys">golang.org/x/sys
> </a>,
>  has been created to serve as the location for new developments to support
> system
>  calls on all kernels.
>  It has a nicer structure, with three packages that each hold the
> implementation of
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-11-06 17:26:41]

I guess we could do that. If you're viewing localhost http I don't see why
you need to go to golang.org on http though.

[bradfitz, 2014-11-06 17:30:57]

LGTM as-is

I just wanted to make sure I understood. Always https is fine.

On Thu, Nov 6, 2014 at 11:46 AM, <rsc@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: adg, golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> doc: change "/s/..." links to be on golang.org
>
> People viewing this locally will not have a /s/ on their local godoc.
> tip.golang.org doesn't have one either.
>
> Also change all golang.org links to https, to avoid mixed content
> warnings when viewing https://golang.org/.
>
> Fixes issue 9028.
>
> Please review this at https://codereview.appspot.com/168250043/
>
> Affected files (+8, -8 lines):
>   M doc/go1.4.html
>
>
> Index: doc/go1.4.html
> ===================================================================
> --- a/doc/go1.4.html
> +++ b/doc/go1.4.html
> @@ -120,9 +120,9 @@
>  <p>
>  Go 1.4 can build binaries for ARM processors running the Android
> operating system.
>  It can also build a <code>.so</code> library that can be loaded by an
> Android application
> -using the supporting packages in the <a
href="http://golang.org/x/mobile">mobile</a>
> subrepository.
> +using the supporting packages in the <a
href="https://golang.org/x/mobile">mobile</a>
> subrepository.
>  A brief description of the plans for this experimental port are available
> -<a href="/s/go14android">here</a>.
> +<a href="//golang.org/s/go14android">here</a>.
>  </p>
>
>  <h3 id="naclarm">NaCl on ARM</h3>
> @@ -193,7 +193,7 @@
>  When a stack limit is reached, a new, larger stack is allocated, all
> active frames for
>  the goroutine are copied there, and any pointers into the stack are
> updated.
>  Performance can be noticeably better in some cases and is always more
> predictable.
> -Details are available in <a href="/s/contigstacks">the design
> document</a>.
> +Details are available in <a href="https://golang.org/s/contigstacks">the
> design document</a>.
>  </p>
>
>  <p>
> @@ -320,7 +320,7 @@
>
>  <p>
>  Full details of the mechanism are in
> -<a href="http://golang.org/s/go14internal">the design document</a>.
> +<a href="https://golang.org/s/go14internal">the design document</a>.
>  </p>
>
>  <h3 id="canonicalimports">Canonical import paths</h3>
> @@ -382,7 +382,7 @@
>
>  <p>
>  Further information is in
> -<a href="http://golang.org/s/go14customimport">the design document</a>.
> +<a href="https://golang.org/s/go14customimport">the design document</a>.
>  </p>
>
>  <h3 id="subrepo">Import paths for the subrepositories</h3>
> @@ -418,7 +418,7 @@
>
>  <p>
>  For more information, see the
> -<a href="http://golang.org/s/go1.4-generate">design document</a>.
> +<a href="https://golang.org/s/go1.4-generate">design document</a>.
>  </p>
>
>  <h3 id="filenames">Change to file name handling</h3>
> @@ -604,12 +604,12 @@
>  for changes needed to maintain the core repository.
>  In particular, it will no longer be extended to support new or different
> system calls
>  that are not used by the core.
> -The reasons are described at length in <a href="http://golang.org/s/go1.
> 4-syscall">a
> +The reasons are described at length in <a href="https://golang.org/s/
> go1.4-syscall">a
>  separate document</a>.
>  </p>
>
>  <p>
> -A new subrepository, <a href="http://golang.org/x/sys">golang.org/x/sys
> </a>,
> +A new subrepository, <a href="https://golang.org/x/sys">golang.org/x/sys
> </a>,
>  has been created to serve as the location for new developments to support
> system
>  calls on all kernels.
>  It has a nicer structure, with three packages that each hold the
> implementation of
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-11-06 18:43:26]

LGTM

[rsc, 2014-11-06 20:18:52]

*** Submitted as https://code.google.com/p/go/source/detail?r=2e04ff8e8d3b ***

doc: change "/s/..." links to be on golang.org

People viewing this locally will not have a /s/ on their local godoc.
tip.golang.org doesn't have one either.

Also change all golang.org links to https, to avoid mixed content
warnings when viewing https://golang.org/.

Fixes issue 9028.

LGTM=bradfitz, r
R=r, bradfitz
CC=adg, golang-codereviews
https://codereview.appspot.com/168250043