Issue 16820043: code review 16820043: freetype/truetype: handle control value cut-in in MIRP.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16820043: code review 16820043: freetype/truetype: handle control value cut-in in MIRP. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by remyoudompheng

Modified:
11 years, 2 months ago

Reviewers:
nigeltao

CC:
golang-dev, nigeltao, bsiegert

Visibility:
Public.

Description

freetype/truetype: handle control value cut-in in MIRP. The difference is quite large on glyph 509 (period character) of Adobe Source Sans Pro Bold Italic.

Patch Set 1 #

Patch Set 2 : diff -r 26099a7abb40 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 26099a7abb40 https://code.google.com/p/freetype-go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	freetype/truetype/hint.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com, nigeltao@golang.org, bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 2 months ago (2013-10-24 21:21:25 UTC) #1

remyoudompheng

Source Sans Pro Bold Italic still suffers from a slight rounding difference on composite characters ...

11 years, 2 months ago (2013-10-24 21:22:20 UTC) #2

nigeltao

11 years, 2 months ago (2013-10-25 00:02:07 UTC) #4

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=d5f43e03fad9 ***

freetype/truetype: handle control value cut-in in MIRP.

The difference is quite large on glyph 509 (period character)
of Adobe Source Sans Pro Bold Italic.

R=golang-dev, nigeltao, bsiegert
CC=golang-dev
https://codereview.appspot.com/16820043

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages