https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py File asyncio/transports.py (right): https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py#newcode243 asyncio/transports.py:243: assert loop is not None assert is inconsistent with ...
9 years, 5 months ago
(2014-11-05 15:39:50 UTC)
#2
https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py File asyncio/transports.py (right): https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py#newcode243 asyncio/transports.py:243: assert loop is not None assert is inconsistent with ...
9 years, 5 months ago
(2014-11-05 15:39:50 UTC)
#3
https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py File asyncio/transports.py (right): https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py#newcode243 asyncio/transports.py:243: assert loop is not None On 2014/11/05 15:39:50, Andrew ...
9 years, 5 months ago
(2014-11-05 15:49:27 UTC)
#4
9 years, 5 months ago
(2014-11-05 16:04:56 UTC)
#5
On 2014/11/05 15:49:27, haypo_gmail wrote:
> https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py
> File asyncio/transports.py (right):
>
>
https://codereview.appspot.com/168070043/diff/1/asyncio/transports.py#newcode243
> asyncio/transports.py:243: assert loop is not None
> On 2014/11/05 15:39:50, Andrew Svetlov wrote:
> > assert is inconsistent with ctor signature: looking on __init__ the loop
> > parameter has default None value.
>
> Well, that's right but I wanted to use the same prototype than other classes.
> Example with Future:
>
> def __init__(self, *, loop=None):
Yes, Future and others can be constructed with implicit event loop.
But every transport in asyncio requires explicit pass of loop parameter.
Issue 168070043: Move loop attribute to _FlowControlMixin
Created 9 years, 5 months ago by haypo_gmail
Modified 9 years, 5 months ago
Reviewers: GvR, Andrew Svetlov
Base URL:
Comments: 2