Issue 1680047: Allow SecurityTokenDecoder to communicate redirect URL to AuthenticationServletFilter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1680047: Allow SecurityTokenDecoder to communicate redirect URL to AuthenticationServletFilter

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by janluehe

Modified:
13 years, 10 months ago

Reviewers:
Paul Lindner, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Right now, it is impossible for a custom org.apache.shindig.auth.SecurityTokenDecoder to pass a redirect URL to org.apache.shindig.auth.AuthenticationServletFilter#doFilter, for it to issue a redirect instead of returning a 401 ("SC_UNAUTHORIZED") response. The fix is to add a "redirect" field and corresponding accessor method to org.apache.shindig.auth.SecurityTokenException. AuthenticationHandler.InvalidAuthenticationException already has a slot for this.

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
		java/common/src/main/java/org/apache/shindig/auth/SecurityTokenException.java	View		1 chunk	+20 lines, -0 lines	0 comments	Download
		java/common/src/main/java/org/apache/shindig/auth/UrlParameterAuthenticationHandler.java	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Paul Lindner

13 years, 10 months ago (2010-07-02 09:42:48 UTC) #2

seems fine, I'm curious to know how this is used in practice and if we should
implement the redirect behavior in the sample code..

Expand All Messages | Collapse All Messages