[dev.cc] code review 167650043: runtime/cgo: add comment about import _ "unsafe"

runtime/cgo: add comment about import _ "unsafe"

[rsc, 2014-11-12 19:36:09]

Hello r (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to the dev.cc branch of
https://code.google.com/p/go

[bradfitz, 2014-11-12 19:38:25]

LGTM
 On Nov 12, 2014 11:36 AM, <rsc@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to the dev.cc branch of
> https://code.google.com/p/go
>
>
> Description:
> runtime/cgo: add comment about import _ "unsafe"
>
> Please review this at https://codereview.appspot.com/167650043/
>
> Affected files (+6, -6 lines):
>   M src/runtime/cgo/dragonfly.go
>   M src/runtime/cgo/freebsd.go
>   M src/runtime/cgo/iscgo.go
>   M src/runtime/cgo/netbsd.go
>   M src/runtime/cgo/openbsd.go
>   M src/runtime/cgo/setenv.go
>
>
> Index: src/runtime/cgo/dragonfly.go
> ===================================================================
> --- a/src/runtime/cgo/dragonfly.go
> +++ b/src/runtime/cgo/dragonfly.go
> @@ -6,7 +6,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  // Supply environ and __progname, because we don't
>  // link against the standard DragonFly crt0.o and the
> Index: src/runtime/cgo/freebsd.go
> ===================================================================
> --- a/src/runtime/cgo/freebsd.go
> +++ b/src/runtime/cgo/freebsd.go
> @@ -6,7 +6,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  // Supply environ and __progname, because we don't
>  // link against the standard FreeBSD crt0.o and the
> Index: src/runtime/cgo/iscgo.go
> ===================================================================
> --- a/src/runtime/cgo/iscgo.go
> +++ b/src/runtime/cgo/iscgo.go
> @@ -11,7 +11,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  //go:linkname _iscgo runtime.iscgo
>  var _iscgo bool = true
> Index: src/runtime/cgo/netbsd.go
> ===================================================================
> --- a/src/runtime/cgo/netbsd.go
> +++ b/src/runtime/cgo/netbsd.go
> @@ -6,7 +6,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  // Supply environ and __progname, because we don't
>  // link against the standard NetBSD crt0.o and the
> Index: src/runtime/cgo/openbsd.go
> ===================================================================
> --- a/src/runtime/cgo/openbsd.go
> +++ b/src/runtime/cgo/openbsd.go
> @@ -6,7 +6,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  // Supply environ, __progname and __guard_local, because
>  // we don't link against the standard OpenBSD crt0.o and
> Index: src/runtime/cgo/setenv.go
> ===================================================================
> --- a/src/runtime/cgo/setenv.go
> +++ b/src/runtime/cgo/setenv.go
> @@ -6,7 +6,7 @@
>
>  package cgo
>
> -import _ "unsafe"
> +import _ "unsafe" // for go:linkname
>
>  //go:cgo_import_static x_cgo_setenv
>  //go:linkname x_cgo_setenv x_cgo_setenv
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-11-12 19:47:20]

LGTM

[rsc, 2014-11-12 19:54:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=89782ac18f38 ***

[dev.cc] runtime/cgo: add comment about import _ "unsafe"

LGTM=bradfitz, r
R=r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/167650043

[gobot, 2014-11-12 19:59:10]

This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/73fedb93ff98c90b048b98b92efbe08c1d7cfeb3