Issue 167110043: [dev.power64] code review 167110043: test: "fix" live.go test on power64x

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 167110043: [dev.power64] code review 167110043: test: "fix" live.go test on power64x (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by austin

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
rsc, dave_cheney.net, golang-codereviews

Visibility:
Public.

Description

test: "fix" live.go test on power64x On power64x, this one line in live.go reports that t is live because of missing optimization passes. This isn't what this test is trying to test, so shuffle bad40 so that it still accomplishes the intent of the test without also depending on optimization.

Patch Set 1 #

Patch Set 2 : diff -r 533822912c10f28de71190abc4c56505e5966543 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/live.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

austin

Hello rsc, dfc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 ...

10 years, 7 months ago (2014-11-03 20:48:15 UTC) #1

austin

10 years, 7 months ago (2014-11-03 22:25:40 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=179f96c128b0 ***

[dev.power64] test: "fix" live.go test on power64x

On power64x, this one line in live.go reports that t is live
because of missing optimization passes.  This isn't what this
test is trying to test, so shuffle bad40 so that it still
accomplishes the intent of the test without also depending on
optimization.

LGTM=rsc
R=rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/167110043

Expand All Messages | Collapse All Messages