Issue 1670050: Wait AppCache download complete when fetching list of cache entries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1670050: Wait AppCache download complete when fetching list of cache entries

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by viarheichyk

Modified:
13 years, 9 months ago

Reviewers:
razmyslovich, petrashkevich, baran, Anatoli, shahun, sauta, Eran

CC:
webdriver-mobile-eng_google.com

Base URL:
http://webkitdriver.googlecode.com/svn/trunk/hlwk/

Visibility:
Public.

Patch Set 2 : Timeout for appcache download #

Patch Set 3 : Timeout for appcache download #

Patch Set 4 : Timeout for appcache download #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
M	../driver/src/java/org/openqa/selenium/webkit/WebKitDriver.java	View		3 chunks	+14 lines, -2 lines	0 comments	Download
M	WebKit/hl/JavaBindings.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	WebKit/hl/JavaBindings.cpp	View	1	1 chunk	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Eran

http://codereview.appspot.com/1670050/diff/1/2 File WebKit/hl/JavaBindings.cpp (right): http://codereview.appspot.com/1670050/diff/1/2#newcode1966 WebKit/hl/JavaBindings.cpp:1966: while(cached->status() == ApplicationCacheHost::CHECKING || cached->status() == ApplicationCacheHost::DOWNLOADING) 1. Braces ...

13 years, 9 months ago (2010-07-07 16:24:02 UTC) #2

viarheichyk

13 years, 9 months ago (2010-07-08 13:49:55 UTC) #3

baran

13 years, 9 months ago (2010-07-14 10:34:21 UTC) #7

LGTM

http://codereview.appspot.com/1670050/diff/13001/14001
File WebKit/hl/JavaBindings.cpp (right):

http://codereview.appspot.com/1670050/diff/13001/14001#newcode1968
WebKit/hl/JavaBindings.cpp:1968: || cached->status() ==
ApplicationCacheHost::DOWNLOADING) {
|| is indented to far, make it two tabs.

Expand All Messages | Collapse All Messages