Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(501)

Issue 166890043: [dev.garbage] code review 166890043: all: merge dev.power64 (5ad5e85cfb99) into dev.garbage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 8 months ago
Reviewers:
gobot, rlh
CC:
rlh, golang-codereviews
Visibility:
Public.

Description

all: merge dev.power64 (5ad5e85cfb99) into dev.garbage The goal here is to get the big-endian fixes so that in some upcoming code movement for write barriers I don't make them unmergeable.

Patch Set 1 #

Patch Set 2 : diff -r e8dd39a0082cb658a9b648af46fdec319a3bf929 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e8dd39a0082cb658a9b648af46fdec319a3bf929 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e8dd39a0082cb658a9b648af46fdec319a3bf929 https://code.google.com/p/go/ #

Patch Set 5 : diff -r e8dd39a0082cb658a9b648af46fdec319a3bf929 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39440 lines, -2844 lines) Patch
M .hgignore View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M include/link.h View 1 2 3 4 7 chunks +19 lines, -8 lines 0 comments Download
M lib/codereview/codereview.cfg View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M lib/codereview/codereview.py View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
M src/cmd/5a/a.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/5a/a.y View 1 2 3 4 3 chunks +10 lines, -16 lines 0 comments Download
M src/cmd/5a/y.tab.h View 1 2 3 4 3 chunks +22 lines, -46 lines 0 comments Download
M src/cmd/5a/y.tab.c View 1 2 3 4 80 chunks +968 lines, -1115 lines 0 comments Download
M src/cmd/6a/a.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/6a/a.y View 1 2 3 4 3 chunks +9 lines, -16 lines 0 comments Download
M src/cmd/6a/y.tab.c View 1 2 3 4 44 chunks +573 lines, -589 lines 0 comments Download
M src/cmd/8a/a.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/8a/a.y View 1 2 3 4 3 chunks +9 lines, -16 lines 0 comments Download
M src/cmd/8a/y.tab.c View 1 2 3 4 43 chunks +548 lines, -562 lines 0 comments Download
M src/cmd/9a/Makefile View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/cmd/9a/a.h View 1 2 3 4 1 chunk +170 lines, -0 lines 0 comments Download
M src/cmd/9a/a.y View 1 2 3 4 1 chunk +991 lines, -0 lines 0 comments Download
M src/cmd/9a/doc.go View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M src/cmd/9a/lex.c View 1 2 3 4 1 chunk +725 lines, -0 lines 0 comments Download
M src/cmd/9a/y.tab.h View 1 2 3 4 1 chunk +188 lines, -0 lines 0 comments Download
M src/cmd/9a/y.tab.c View 1 2 3 4 1 chunk +3398 lines, -0 lines 0 comments Download
M src/cmd/9c/Makefile View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/9c/Notes View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M src/cmd/9c/cgen.c View 1 2 3 4 1 chunk +1147 lines, -0 lines 0 comments Download
M src/cmd/9c/doc.go View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M src/cmd/9c/gc.h View 1 2 3 4 1 chunk +350 lines, -0 lines 0 comments Download
M src/cmd/9c/list.c View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M src/cmd/9c/machcap.c View 1 2 3 4 1 chunk +105 lines, -0 lines 0 comments Download
M src/cmd/9c/mul.c View 1 2 3 4 1 chunk +638 lines, -0 lines 0 comments Download
M src/cmd/9c/peep.c View 1 2 3 4 1 chunk +1076 lines, -0 lines 0 comments Download
M src/cmd/9c/reg.c View 1 2 3 4 1 chunk +1163 lines, -0 lines 0 comments Download
M src/cmd/9c/sgen.c View 1 2 3 4 1 chunk +291 lines, -0 lines 0 comments Download
M src/cmd/9c/swt.c View 1 2 3 4 1 chunk +407 lines, -0 lines 0 comments Download
M src/cmd/9c/txt.c View 1 2 3 4 1 chunk +1537 lines, -0 lines 0 comments Download
M src/cmd/9g/cgen.c View 1 2 3 4 1 chunk +1763 lines, -0 lines 0 comments Download
M src/cmd/9g/doc.go View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M src/cmd/9g/galign.c View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
M src/cmd/9g/gg.h View 1 2 3 4 1 chunk +117 lines, -0 lines 0 comments Download
M src/cmd/9g/ggen.c View 1 2 3 4 1 chunk +1034 lines, -0 lines 0 comments Download
M src/cmd/9g/gobj.c View 1 2 3 4 1 chunk +240 lines, -0 lines 0 comments Download
M src/cmd/9g/gsubr.c View 1 2 3 4 1 chunk +1705 lines, -0 lines 0 comments Download
M src/cmd/9g/opt.h View 1 2 3 4 1 chunk +219 lines, -0 lines 0 comments Download
M src/cmd/9g/peep.c View 1 2 3 4 1 chunk +94 lines, -0 lines 0 comments Download
M src/cmd/9g/prog.c View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download
M src/cmd/9g/reg.c View 1 2 3 4 1 chunk +161 lines, -0 lines 0 comments Download
M src/cmd/9l/9.out.h View 1 2 3 4 1 chunk +514 lines, -0 lines 0 comments Download
M src/cmd/9l/Makefile View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/9l/asm.c View 1 2 3 4 1 chunk +338 lines, -0 lines 0 comments Download
M src/cmd/9l/doc.go View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M src/cmd/9l/l.h View 1 2 3 4 1 chunk +100 lines, -0 lines 0 comments Download
M src/cmd/9l/list.c View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M src/cmd/9l/obj.c View 1 2 3 4 1 chunk +108 lines, -0 lines 0 comments Download
M src/cmd/cc/lexbody View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M src/cmd/cc/pgen.c View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/cgo/main.go View 1 2 3 4 1 chunk +14 lines, -6 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 3 4 10 chunks +44 lines, -5 lines 0 comments Download
M src/cmd/dist/buildgc.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/dist/buildruntime.c View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/dist/unix.c View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/gc/pgen.c View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/gc/popt.c View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M src/cmd/ld/data.c View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M src/cmd/ld/doc.go View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/ld/dwarf.c View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/ld/elf.c View 1 2 3 4 12 chunks +18 lines, -11 lines 0 comments Download
M src/cmd/ld/ldelf.c View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 1 2 3 4 11 chunks +19 lines, -17 lines 0 comments Download
M src/cmd/ld/macho.c View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/symtab.c View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/elf/elf.go View 1 2 3 4 1 chunk +178 lines, -0 lines 0 comments Download
M src/debug/elf/file.go View 1 2 3 4 3 chunks +49 lines, -1 line 0 comments Download
M src/debug/elf/file_test.go View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/debug/elf/testdata/go-relocation-test-gcc482-ppc64le.obj View 1 2 3 4 Binary file 0 comments Download
M src/go/build/build.go View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/go/build/syslist.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/hash/crc32/crc32_generic.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/liblink/asm9.c View 1 2 3 4 1 chunk +2784 lines, -0 lines 0 comments Download
M src/liblink/list9.c View 1 2 3 4 1 chunk +409 lines, -0 lines 0 comments Download
M src/liblink/obj9.c View 1 2 3 4 1 chunk +1086 lines, -0 lines 0 comments Download
M src/liblink/objfile.c View 1 2 3 4 3 chunks +7 lines, -2 lines 0 comments Download
M src/liblink/sched9.c View 1 2 3 4 1 chunk +835 lines, -0 lines 0 comments Download
M src/math/abs_power64x.s View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M src/math/big/arith_power64x.s View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
M src/math/stubs_power64x.s View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
M src/os/signal/sig.s View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/reflect/all_test.go View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/reflect/asm_power64x.s View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M src/runtime/arch_power64.h View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/arch_power64.go View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime/arch_power64le.h View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/arch_power64le.go View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime/asm_386.s View 1 2 3 4 5 chunks +29 lines, -29 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 2 3 4 8 chunks +39 lines, -39 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 2 3 4 6 chunks +29 lines, -29 lines 0 comments Download
M src/runtime/asm_arm.s View 1 2 3 4 5 chunks +12 lines, -12 lines 0 comments Download
M src/runtime/asm_power64x.s View 1 2 3 4 1 chunk +981 lines, -0 lines 0 comments Download
M src/runtime/atomic_power64x.s View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M src/runtime/debug/stubs.s View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/defs1_linux.go View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/defs3_linux.go View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
M src/runtime/defs_linux.go View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/defs_linux_power64.h View 1 2 3 4 1 chunk +204 lines, -0 lines 0 comments Download
M src/runtime/defs_linux_power64le.h View 1 2 3 4 1 chunk +204 lines, -0 lines 0 comments Download
M src/runtime/gcinfo_test.go View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/malloc.go View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/mem_linux.c View 1 2 3 4 3 chunks +10 lines, -6 lines 0 comments Download
M src/runtime/memclr_386.s View 1 2 3 4 4 chunks +23 lines, -23 lines 0 comments Download
M src/runtime/memclr_amd64.s View 1 2 3 4 3 chunks +22 lines, -22 lines 0 comments Download
M src/runtime/memclr_plan9_386.s View 1 2 3 4 1 chunk +12 lines, -12 lines 0 comments Download
M src/runtime/memclr_power64x.s View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
M src/runtime/memmove_power64x.s View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M src/runtime/mgc0.c View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/noasm.go View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
R src/runtime/noasm_arm.go View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
M src/runtime/os_linux.c View 1 2 3 4 3 chunks +27 lines, -10 lines 0 comments Download
M src/runtime/panic.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/panic.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/proc.c View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/race_amd64.s View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M src/runtime/rt0_linux_power64.s View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M src/runtime/rt0_linux_power64le.s View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/runtime.c View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M src/runtime/signal_linux_power64.h View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
M src/runtime/signal_linux_power64le.h View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
M src/runtime/signal_power64x.c View 1 2 3 4 1 chunk +137 lines, -0 lines 0 comments Download
M src/runtime/string.go View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/sys_darwin_386.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_darwin_amd64.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_dragonfly_386.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_freebsd_386.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_linux_amd64.s View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/sys_linux_arm.s View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime/sys_linux_power64x.s View 1 2 3 4 1 chunk +383 lines, -0 lines 0 comments Download
M src/runtime/sys_nacl_386.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_nacl_amd64p32.s View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/sys_nacl_arm.s View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/sys_openbsd_386.s View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sys_power64x.c View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M src/runtime/sys_solaris_amd64.s View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/sys_windows_386.s View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/sys_windows_amd64.s View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/thunk.s View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/sync/atomic/asm_power64x.s View 1 2 3 4 1 chunk +184 lines, -0 lines 0 comments Download
M src/syscall/asm.s View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M src/syscall/asm_linux_power64x.s View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
M src/syscall/mkall.sh View 1 2 3 4 3 chunks +16 lines, -1 line 0 comments Download
M src/syscall/mkerrors.sh View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/syscall/syscall_linux_power64x.go View 1 2 3 4 1 chunk +97 lines, -0 lines 0 comments Download
M src/syscall/types_linux.go View 1 2 3 4 3 chunks +9 lines, -101 lines 0 comments Download
M src/syscall/zerrors_linux_power64.go View 1 2 3 4 1 chunk +1878 lines, -0 lines 0 comments Download
M src/syscall/zerrors_linux_power64le.go View 1 2 3 4 1 chunk +1902 lines, -0 lines 0 comments Download
M src/syscall/zsyscall_linux_power64.go View 1 2 3 4 1 chunk +1931 lines, -0 lines 0 comments Download
M src/syscall/zsyscall_linux_power64le.go View 1 2 3 4 1 chunk +1931 lines, -0 lines 0 comments Download
M src/syscall/zsysnum_linux_power64.go View 1 2 3 4 1 chunk +351 lines, -0 lines 0 comments Download
M src/syscall/zsysnum_linux_power64le.go View 1 2 3 4 1 chunk +351 lines, -0 lines 0 comments Download
M src/syscall/ztypes_linux_power64.go View 1 2 3 4 1 chunk +602 lines, -0 lines 0 comments Download
M src/syscall/ztypes_linux_power64le.go View 1 2 3 4 1 chunk +602 lines, -0 lines 0 comments Download
M test/nosplit.go View 1 2 3 4 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 8 months ago (2014-10-29 16:07:02 UTC) #1
rlh
LGTM
10 years, 8 months ago (2014-10-29 16:19:27 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=6d4befa34ca3 *** [dev.garbage] all: merge dev.power64 (5ad5e85cfb99) into dev.garbage The goal here ...
10 years, 8 months ago (2014-10-29 16:25:33 UTC) #3
gobot
10 years, 8 months ago (2014-10-29 16:49:58 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the openbsd-amd64-rootbsd builder.
See http://build.golang.org/log/f92064e40fd04bfae3e84651810232f9a105b786
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b