Issue 166740043: code review 166740043: net: add test for lookupIPDeadline

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166740043: code review 166740043: net: add test for lookupIPDeadline (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by mikio

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

net: add test for lookupIPDeadline Just to confirm the fix, by typing the follwing: go test -run=TestLookupIPDeadline -dnsflood or go test -run=TestLookupIPDeadline -dnsflood -tags netgo Update issue 8602

Patch Set 1 : diff -r 420519ee6049c79f2a36a2e7c553adec992c104e https://code.google.com/p/go #

Patch Set 2 : diff -r 420519ee6049c79f2a36a2e7c553adec992c104e https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r c0c7fc02a32dc5c6d9a7cf0d93b7d851224a005b https://code.google.com/p/go #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -0 lines)			Patch
	M	src/net/z_last_test.go	View	1 2	2 chunks	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 5 months ago (2014-10-28 03:14:17 UTC) #1

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 5 months ago (2014-10-28 03:38:56 UTC) #2

iant

LGTM https://codereview.appspot.com/166740043/diff/60001/src/net/z_last_test.go File src/net/z_last_test.go (right): https://codereview.appspot.com/166740043/diff/60001/src/net/z_last_test.go#newcode90 src/net/z_last_test.go:90: t.Logf("%v succeeded, %v failed (%v timeout, %v temporary, ...

9 years, 5 months ago (2014-10-28 04:41:49 UTC) #3

mikio

9 years, 5 months ago (2014-10-28 07:20:56 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c3481212573b ***

net: add test for lookupIPDeadline

Just to confirm the fix, by typing the follwing:
go test -run=TestLookupIPDeadline -dnsflood or
go test -run=TestLookupIPDeadline -dnsflood -tags netgo

Update issue 8602

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/166740043

https://codereview.appspot.com/166740043/diff/60001/src/net/z_last_test.go
File src/net/z_last_test.go (right):

https://codereview.appspot.com/166740043/diff/60001/src/net/z_last_test.go#ne...
src/net/z_last_test.go:90: t.Logf("%v succeeded, %v failed (%v timeout, %v
temporary, %v other, %v unknown)", qstats.succeeded, qstats.failed,
qstats.timeout, qstats.temporary, qstats.other, qstats.unknown)
On 2014/10/28 04:41:49, iant wrote:
> Please add a comment saying what kinds of numbers are expected here.

Done.

Expand All Messages | Collapse All Messages