Issue 166720043: code review 166720043: goprotobuf: Miscellaneous cleanups.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166720043: code review 166720043: goprotobuf: Miscellaneous cleanups. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by dsymonds

Modified:
9 years, 6 months ago

Reviewers:
nigeltao

CC:
nigeltao, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Miscellaneous cleanups. No significant changes except for debuggers.

Patch Set 2 : diff -r 725eb0907b649c438e0e8f1601648597141fb66c https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 725eb0907b649c438e0e8f1601648597141fb66c https://code.google.com/p/goprotobuf #

Total comments: 1

Patch Set 4 : diff -r 725eb0907b649c438e0e8f1601648597141fb66c https://code.google.com/p/goprotobuf #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	proto/decode.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/equal.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/properties.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello nigeltao (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

9 years, 6 months ago (2014-10-27 23:43:41 UTC) #1

nigeltao

LGTM. https://codereview.appspot.com/166720043/diff/40001/protoc-gen-go/generator/generator.go File protoc-gen-go/generator/generator.go (right): https://codereview.appspot.com/166720043/diff/40001/protoc-gen-go/generator/generator.go#newcode245 protoc-gen-go/generator/generator.go:245: This blank line looks weird.

9 years, 6 months ago (2014-10-27 23:57:11 UTC) #2

dsymonds

On 28 October 2014 10:57, <nigeltao@golang.org> wrote: > This blank line looks weird. Yeah, because ...

9 years, 6 months ago (2014-10-28 00:00:24 UTC) #3

dsymonds

9 years, 6 months ago (2014-10-28 00:00:58 UTC) #4

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=4fab5f02651f ***

goprotobuf: Miscellaneous cleanups.

No significant changes except for debuggers.

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/166720043

Expand All Messages | Collapse All Messages