Issue 16670043: Use separate mirrors file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16670043: Use separate mirrors file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
gz, mp+192558

Visibility:
Public.

Description

Use separate mirrors file simplestreams now requires the mirrors index information be in a separate mirrors file rather than the index file. https://code.launchpad.net/~wallyworld/juju-core/simplestreams-separate-mirrors/+merge/192558 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/simplestreams/simplestreams.go	View	3 chunks	+26 lines, -3 lines	1 comment	Download
M	environs/simplestreams/testing/testing.go	View	2 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

10 years, 6 months ago (2013-10-25 00:27:51 UTC) #2

LGTM.

https://codereview.appspot.com/16670043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams.go (right):

https://codereview.appspot.com/16670043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:501: return nil, fmt.Errorf("cannot
unmarshal JSON mirror metadata at URL %q: %v", url, err)
Can you update this error message as the error may not be from unmarshalling
json.

Expand All Messages | Collapse All Messages