Issue 1665046: Some warning cleanup for Eclipse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1665046: Some warning cleanup for Eclipse (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 12 months ago by MikeSamuel

Modified:
15 years, 11 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Get rid of JSONObject uses which trigger generic warnings since JSONObject implements generic map. Remove unused imports and fix some possible null pointer access problems. Submitted @4174

Patch Set 1 #

Patch Set 2 : Some warning cleanup for Eclipse #

Patch Set 3 : Some warning cleanup for Eclipse #

Patch Set 4 : Some warning cleanup for Eclipse #

Patch Set 5 : Some warning cleanup for Eclipse #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -117 lines)			Patch
M	src/com/google/caja/ancillary/servlet/UserAgentDb.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/config/ConfigUtil.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/config/WhiteList.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/lexer/escaping/Escaping.java	View	2 3 4	2 chunks	+45 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/html/AbstractElementStack.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/html/Nodes.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/ObjectConstructor.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/StringLiteral.java	View	2 3 4	1 chunk	+10 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/InlineCssImportsStage.java	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/OpenTemplateStage.java	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/templates/TemplateSanitizer.java	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/render/Concatenator.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
D	src/com/google/caja/reporting/MessageGroup.java	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	src/com/google/caja/reporting/MessageQueue.java	View		1 chunk	+21 lines, -3 lines	0 comments	Download
M	src/com/google/caja/service/AbstractCajolingHandler.java	View	1 2 3 4	4 chunks	+58 lines, -19 lines	0 comments	Download
M	src/com/google/caja/service/HtmlHandler.java	View	1 2 3 4	3 chunks	+3 lines, -20 lines	0 comments	Download
M	src/com/google/caja/service/JsHandler.java	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/tools/AbstractCajaAntTask.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/util/Lists.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/util/Maps.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/util/Sets.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/util/Strings.java	View	3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/lexer/escaping/EscapingTest.java	View	2 3 4	1 chunk	+24 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/DomitaTest.java	View	3 4	3 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/com/google/caja/service/HtmlHandlerTest.java	View	1 2 3 4	4 chunks	+5 lines, -7 lines	0 comments	Download
M	tests/com/google/caja/service/JsHandlerTest.java	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/com/google/caja/service/ServiceTestCase.java	View	2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/util/CollectionsTest.java	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages