code review 1664053: utf16: Fix recursive call ... linker skew error

utf16: Fix recursive call ... linker skew error
The utf16 test, run using Windows, fails with the message:
throw: recursive call during initialization - linker skew.
syscall_windows.go depends on the utf16 package.

[peterGo, 2010-07-17 20:19:51]

This is a cheap, but ugly, fix. Is there a better way?

Windows NT first used UTF-2 and now uses UTF-16. Therefore, syscall_windows.go
introduced some unfortunate utf16 package dependencies. Running Windows, the
utf16 test fails with the message 'throw: recursive call during initialization -
linker skew'.

..cd utf16 && p:/utf16/bin/gomake test

make[1]: Entering directory `/p/utf16/src/pkg/utf16'

p:/utf16/bin/gotest

make[2]: Entering directory `/p/utf16/src/pkg/utf16'

rm -f _test/utf16.a _gotest_.8

make[2]: Leaving directory `/p/utf16/src/pkg/utf16'

make[2]: Entering directory `/p/utf16/src/pkg/utf16'

p:/utf16/bin/8g -o _gotest_.8 utf16.go  utf16_test.go

rm -f _test/utf16.a

p:/utf16/bin/gopack grc _test/utf16.a _gotest_.8

make[2]: Leaving directory `/p/utf16/src/pkg/utf16'

throw: recursive call during initialization - linker skew



panic PC=0x53ae10

throw+0x48 /utf16/src/pkg/runtime/runtime.c:73

        throw(0xffffffff, 0x444513)

runtime.throwinit+0x26 /utf16/src/pkg/runtime/runtime.c:64

        runtime.throwinit()

testing.Init┬╖+0x3a testing.go:174

        testing.Init┬╖()

utf16.Init┬╖+0x46 utf16_test.go:117

        utf16.Init┬╖()

syscall.Init┬╖+0x53 ztypes_windows_386.go:294

        syscall.Init┬╖()

time.Init┬╖+0x4b zoneinfo_windows.go:191

        time.Init┬╖()

testing.Init┬╖+0x50 testing.go:174

        testing.Init┬╖()

main.init+0x46 _testmain.go:17

        main.init()

mainstart+0x5 386/asm.s:81

        mainstart()

goexit /utf16/src/pkg/runtime/proc.c:145

        goexit()

make[1]: *** [test] Error 41

make[1]: Leaving directory `/p/utf16/src/pkg/utf16'

make: *** [utf16.test] Error 2

[peterGo, 2010-07-17 20:22:08]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-07-17 23:49:30]

LGTM

That's the fix.
All the tests for packages imported (even indirectly)
by testing have to be written that way.

Thanks.

[rsc, 2010-07-17 23:52:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=23eae2974d2c ***

utf16: fix cyclic dependency when testing on Windows

(on Windows, syscall depends on utf16)

R=rsc
CC=golang-dev
http://codereview.appspot.com/1664053

Committer: Russ Cox <rsc@golang.org>