Issue 16600043: add robust simplestreams cloud matching

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16600043: add robust simplestreams cloud matching (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+192536, fwereade

Visibility:
Public.

Description

add robust simplestreams cloud matching Allow auth urls to have trailing "/" (or not) and simplestreams will still work as expected. https://code.launchpad.net/~wallyworld/juju-core/simplestreams-cloud-match/+merge/192536 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -13 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/simplestreams/simplestreams.go	View	4 chunks	+20 lines, -3 lines	2 comments	Download
M	environs/simplestreams/simplestreams_test.go	View	10 chunks	+30 lines, -10 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simplestreams.go File environs/simplestreams/simplestreams.go (right): https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simplestreams.go#newcode41 environs/simplestreams/simplestreams.go:41: func (spec *CloudSpec) equals(other *CloudSpec) bool { Maybe ...

10 years, 6 months ago (2013-10-24 18:18:34 UTC) #2

wallyworld

10 years, 6 months ago (2013-10-24 21:04:27 UTC) #3

https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams.go (right):

https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams.go:41: func (spec *CloudSpec) equals(other
*CloudSpec) bool {
On 2013/10/24 18:18:34, fwereade wrote:
> Maybe nicer to pass by value?

I wanted consistency between the receiver type (*spec) and the function argument
(*other). Since this is equals(), I felt it better for some reason

https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams_test.go (right):

https://codereview.appspot.com/16600043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams_test.go:174:
c.Check(simplestreams.HasCloud(metadata, spec), jc.IsTrue)
On 2013/10/24 18:18:34, fwereade wrote:
> Explicit checks for perfect matches, just for pedantry's sake? Maybe that's
just
> duplicating others.

It is done elsewhere but I'll add here too just in case

Expand All Messages | Collapse All Messages